SNOW-1866382 ensure OCSP mode is by default set to FAIL_OPEN (#827)

Author: sfc-gh-mmishchenko

tests/test_ocsp_fail_open.c

@@ -4,8 +4,6 @@
 
 #include "utils/test_setup.h"
 
-#define FAIL_OPEN_DEFAULT SF_BOOLEAN_TRUE
-
 void setCacheFile(char *cache_file)
 {
 #ifdef __linux__
@@ -40,7 +38,18 @@ void setCacheFile(char *cache_file)
 #endif
 }
 
+void test_fail_open_is_default_mode(void **unused) {
+    SF_UNUSED(unused);
+    SF_CONNECT *sf = snowflake_init();
+    sf_bool *ocsp_fail_open = NULL;
+    SF_STATUS ret = snowflake_get_attribute(sf, SF_CON_OCSP_FAIL_OPEN, (void**)&ocsp_fail_open);
+    assert_int_equal(ret, SF_STATUS_SUCCESS);
+    assert_int_equal(*ocsp_fail_open, SF_BOOLEAN_TRUE);
+    snowflake_term(sf);
+}
+
 void test_fail_open_revoked(void **unused) {
+    SF_UNUSED(unused);
     char cache_file[4096];
     setCacheFile(cache_file);
     remove(cache_file);
@@ -49,13 +58,6 @@ void test_fail_open_revoked(void **unused) {
     sf_setenv("SF_OCSP_RESPONSE_CACHE_SERVER_ENABLED", "false");
 
     SF_CONNECT *sf = setup_snowflake_connection();
-
-    sf_bool value = SF_BOOLEAN_TRUE;
-    if (value != FAIL_OPEN_DEFAULT)
-    {
-        snowflake_set_attribute(sf, SF_CON_OCSP_FAIL_OPEN, &value);
-    }
-
     SF_STATUS ret = snowflake_connect(sf);
     assert_int_not_equal(ret, SF_STATUS_SUCCESS); // must fail
     SF_ERROR_STRUCT *sferr = snowflake_error(sf);
@@ -67,6 +69,7 @@ void test_fail_open_revoked(void **unused) {
 }
 
 void test_fail_close_timeout(void** unused) {
+    SF_UNUSED(unused);
     char cache_file[4096];
     setCacheFile(cache_file);
     remove(cache_file);
@@ -76,11 +79,7 @@ void test_fail_close_timeout(void** unused) {
     sf_setenv("SF_OCSP_RESPONSE_CACHE_SERVER_ENABLED", "false");
 
     SF_CONNECT* sf = setup_snowflake_connection();
-    sf_bool value = SF_BOOLEAN_FALSE;
-    if (value != FAIL_OPEN_DEFAULT)
-    {
-        snowflake_set_attribute(sf, SF_CON_OCSP_FAIL_OPEN, &value);
-    }
+    snowflake_set_attribute(sf, SF_CON_OCSP_FAIL_OPEN, &SF_BOOLEAN_FALSE);
 
     SF_STATUS ret = snowflake_connect(sf);
     assert_int_not_equal(ret, SF_STATUS_SUCCESS); // must fail
@@ -93,6 +92,7 @@ void test_fail_close_timeout(void** unused) {
 }
 
 void test_fail_open_timeout(void** unused) {
+    SF_UNUSED(unused);
     char cache_file[4096];
     setCacheFile(cache_file);
     remove(cache_file);
@@ -102,12 +102,6 @@ void test_fail_open_timeout(void** unused) {
     sf_setenv("SF_OCSP_RESPONSE_CACHE_SERVER_ENABLED", "false");
 
     SF_CONNECT* sf = setup_snowflake_connection();
-    sf_bool value = SF_BOOLEAN_TRUE;
-    if (value != FAIL_OPEN_DEFAULT)
-    {
-        snowflake_set_attribute(sf, SF_CON_OCSP_FAIL_OPEN, &value);
-    }
-
     SF_STATUS ret = snowflake_connect(sf);
     if (ret != SF_STATUS_SUCCESS) {
         dump_error(&(sf->error));
@@ -119,6 +113,7 @@ void test_fail_open_timeout(void** unused) {
 int main(void) {
     initialize_test(SF_BOOLEAN_FALSE);
     const struct CMUnitTest tests[] = {
+        cmocka_unit_test(test_fail_open_is_default_mode),
         cmocka_unit_test(test_fail_open_revoked),
         cmocka_unit_test(test_fail_close_timeout),
         cmocka_unit_test(test_fail_open_timeout),