SNOW-1270256 - Concurrency bug around ResultSet and Session parameters (#1682)

sfc-gh-dkiriaev · web-flow · commit e4f2f9465a5b · 2024-03-28T07:22:34.000+01:00
diff --git a/src/main/java/net/snowflake/client/jdbc/SnowflakeResultSetSerializableV1.java b/src/main/java/net/snowflake/client/jdbc/SnowflakeResultSetSerializableV1.java
@@ -599,7 +599,7 @@ public static SnowflakeResultSetSerializableV1 create(
     resultSetSerializable.parameters =
         SessionUtil.getCommonParams(rootNode.path("data").path("parameters"));
     if (resultSetSerializable.parameters.isEmpty()) {
-      resultSetSerializable.parameters = sfSession.getCommonParameters();
+      resultSetSerializable.parameters = new HashMap<>(sfSession.getCommonParameters());
       resultSetSerializable.setStatemementLevelParameters(sfStatement.getStatementParameters());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -599,7 +599,7 @@ public static SnowflakeResultSetSerializableV1 create(`
`599`	`599`	`resultSetSerializable.parameters =`
`600`	`600`	`SessionUtil.getCommonParams(rootNode.path("data").path("parameters"));`
`601`	`601`	`if (resultSetSerializable.parameters.isEmpty()) {`
`602`		`- resultSetSerializable.parameters = sfSession.getCommonParameters();`
	`602`	`+ resultSetSerializable.parameters = new HashMap<>(sfSession.getCommonParameters());`
`603`	`603`	`resultSetSerializable.setStatemementLevelParameters(sfStatement.getStatementParameters());`
`604`	`604`	`}`
`605`	`605`