SNOW-1965573 Fix file cache creation on windows (#2115)

Author: sfc-gh-pfus

src/main/java/net/snowflake/client/core/FileCacheManager.java

@@ -141,14 +141,18 @@ synchronized FileCacheManager build() {
     }
     if (!cacheDir.exists()) {
       try {
-        Files.createDirectories(
-            cacheDir.toPath(),
-            PosixFilePermissions.asFileAttribute(
-                Stream.of(
-                        PosixFilePermission.OWNER_READ,
-                        PosixFilePermission.OWNER_WRITE,
-                        PosixFilePermission.OWNER_EXECUTE)
-                    .collect(Collectors.toSet())));
+        if (!isWindows() && onlyOwnerPermissions) {
+          Files.createDirectories(
+              cacheDir.toPath(),
+              PosixFilePermissions.asFileAttribute(
+                  Stream.of(
+                          PosixFilePermission.OWNER_READ,
+                          PosixFilePermission.OWNER_WRITE,
+                          PosixFilePermission.OWNER_EXECUTE)
+                      .collect(Collectors.toSet())));
+        } else {
+          Files.createDirectories(cacheDir.toPath());
+        }
       } catch (IOException e) {
         logger.info(
             "Failed to create the cache directory: {}. Ignored. {}",

src/test/java/net/snowflake/client/core/FileCacheManagerTest.java

@@ -5,6 +5,7 @@
 package net.snowflake.client.core;
 
 import static net.snowflake.client.core.StmtUtil.mapper;
+import static net.snowflake.client.jdbc.SnowflakeUtil.isWindows;
 import static net.snowflake.client.jdbc.SnowflakeUtil.systemGetProperty;
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -168,19 +169,28 @@ private File createCacheFile() {
       if (Files.exists(cacheFile.getParent())) {
         Files.delete(cacheFile.getParent());
       }
-      Files.createDirectories(
-          cacheFile.getParent(),
-          PosixFilePermissions.asFileAttribute(
-              Stream.of(
-                      PosixFilePermission.OWNER_READ,
-                      PosixFilePermission.OWNER_WRITE,
-                      PosixFilePermission.OWNER_EXECUTE)
-                  .collect(Collectors.toSet())));
-      Files.createFile(
-          cacheFile,
-          PosixFilePermissions.asFileAttribute(
-              Stream.of(PosixFilePermission.OWNER_READ, PosixFilePermission.OWNER_WRITE)
-                  .collect(Collectors.toSet())));
+      if (!isWindows()) {
+        Files.createDirectories(
+            cacheFile.getParent(),
+            PosixFilePermissions.asFileAttribute(
+                Stream.of(
+                        PosixFilePermission.OWNER_READ,
+                        PosixFilePermission.OWNER_WRITE,
+                        PosixFilePermission.OWNER_EXECUTE)
+                    .collect(Collectors.toSet())));
+      } else {
+        Files.createDirectories(cacheFile.getParent());
+      }
+
+      if (!isWindows()) {
+        Files.createFile(
+            cacheFile,
+            PosixFilePermissions.asFileAttribute(
+                Stream.of(PosixFilePermission.OWNER_READ, PosixFilePermission.OWNER_WRITE)
+                    .collect(Collectors.toSet())));
+      } else {
+        Files.createFile(cacheFile);
+      }
       ObjectNode cacheContent = mapper.createObjectNode();
       cacheContent.put("token", "tokenValue");
       fileCacheManager.overrideCacheFile(cacheFile.toFile());
@@ -199,4 +209,17 @@ private Path createSymlink() throws IOException {
     }
     return Files.createSymbolicLink(link, cacheFile.toPath());
   }
+
+  @Test
+  void shouldCreateDirAndFile() {
+    String tmpDirPath = System.getProperty("java.io.tmpdir");
+    String cacheDirPath = tmpDirPath + File.separator + "snowflake-cache-dir";
+    System.setProperty("FILE_CACHE_MANAGER_SHOULD_CREATE_DIR_AND_FILE", cacheDirPath);
+    FileCacheManager.builder()
+        .setOnlyOwnerPermissions(false)
+        .setCacheDirectorySystemProperty("FILE_CACHE_MANAGER_SHOULD_CREATE_DIR_AND_FILE")
+        .setBaseCacheFileName("cache-file")
+        .build();
+    assertTrue(new File(tmpDirPath).exists());
+  }
 }