Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1895884: Token cache refactor #2044

Merged
merged 26 commits into from
Feb 13, 2025
Merged

SNOW-1895884: Token cache refactor #2044

merged 26 commits into from
Feb 13, 2025

Conversation

sfc-gh-dheyman
Copy link
Contributor

@sfc-gh-dheyman sfc-gh-dheyman commented Jan 24, 2025 •
edited
Loading

Overview

SNOW-1895884

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-dheyman sfc-gh-dheyman marked this pull request as ready for review January 29, 2025 15:02
@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner January 29, 2025 15:02
@gitguardian GitGuardian
Copy link

gitguardian bot commented Jan 30, 2025 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-dheyman sfc-gh-dheyman force-pushed the SNOW-1895884-token-cache-keys branch from 74bfcd6 to 6575f5d Compare January 31, 2025 09:18
sfc-gh-pfus
sfc-gh-pfus reviewed Feb 5, 2025
View reviewed changes
sfc-gh-jszczerbinski
sfc-gh-jszczerbinski approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dheyman sfc-gh-dheyman merged commit ab79d24 into oauth-code-flow Feb 13, 2025
4 of 5 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the SNOW-1895884-token-cache-keys branch February 13, 2025 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa left review comments

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski sfc-gh-jszczerbinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-dheyman @sfc-gh-pbulawa @sfc-gh-pmotacki @sfc-gh-pfus @sfc-gh-jszczerbinski