Set a query count var for incrementing in future tests; simplifies future refactoring

drbyte · drbyte · commit 18825c62216f · 2025-02-16T13:12:40.000-05:00
diff --git a/tests/HasPermissionsTest.php b/tests/HasPermissionsTest.php
@@ -708,7 +708,9 @@ public function it_does_not_run_unnecessary_sqls_when_assigning_new_permissions(
         $this->testUser->syncPermissions($this->testUserPermission, $permission2);
         DB::disableQueryLog();
 
-        $this->assertSame(2, count(DB::getQueryLog())); // avoid unnecessary sqls
+        $necessaryQueriesCount = 2;
+
+        $this->assertCount($necessaryQueriesCount, DB::getQueryLog());
     }
 
     /** @test */
diff --git a/tests/HasRolesTest.php b/tests/HasRolesTest.php
@@ -393,7 +393,9 @@ public function it_does_not_run_unnecessary_sqls_when_assigning_new_roles()
         $this->testUser->syncRoles($this->testUserRole, $role2);
         DB::disableQueryLog();
 
-        $this->assertSame(2, count(DB::getQueryLog())); // avoid unnecessary sqls
+        $necessaryQueriesCount = 2;
+
+        $this->assertCount($necessaryQueriesCount, DB::getQueryLog());
     }
 
     /** @test */

Original file line number	Diff line number	Diff line change
`@@ -708,7 +708,9 @@ public function it_does_not_run_unnecessary_sqls_when_assigning_new_permissions(`
`708`	`708`	`$this->testUser->syncPermissions($this->testUserPermission, $permission2);`
`709`	`709`	`DB::disableQueryLog();`
`710`	`710`
`711`		`- $this->assertSame(2, count(DB::getQueryLog())); // avoid unnecessary sqls`
	`711`	`+ $necessaryQueriesCount = 2;`
	`712`	`+`
	`713`	`+ $this->assertCount($necessaryQueriesCount, DB::getQueryLog());`
`712`	`714`	`}`
`713`	`715`
`714`	`716`	`/** @test */`
Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,9 @@ public function it_does_not_run_unnecessary_sqls_when_assigning_new_roles()`
`393`	`393`	`$this->testUser->syncRoles($this->testUserRole, $role2);`
`394`	`394`	`DB::disableQueryLog();`
`395`	`395`
`396`		`- $this->assertSame(2, count(DB::getQueryLog())); // avoid unnecessary sqls`
	`396`	`+ $necessaryQueriesCount = 2;`
	`397`	`+`
	`398`	`+ $this->assertCount($necessaryQueriesCount, DB::getQueryLog());`
`397`	`399`	`}`
`398`	`400`
`399`	`401`	`/** @test */`