Skip to content

Commit cfa4349

Browse files
committedOct 23, 2024
Apparently MDT is too ambiguous to expect SUTime to get a canonical time zone, unless we add our own locale-aware time zone disambiguator. https://stackoverflow.com/questions/79116972
1 parent c55691c commit cfa4349

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

‎itest/src/edu/stanford/nlp/time/SUTimeITest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ public void testSUIsoWithTimezone() throws IOException {
342342
"ISO datetime is 2004-03-04T18:32:56 Eastern Standard Time.\n" +
343343
"Time is 4:30pm Mountain Time.\n" + // not recognized ?
344344
"Time is 9:30 am Pacific Time.\n" +
345-
"ISO time is T13:23:42 MDT.\n" +
345+
"ISO time is T13:23:42 America/Denver.\n" +
346346
"It is 8:43 PST on 6/12/2008.\n" +
347347
"It is 6:53:32 PDT on 7-16-2010.\n" +
348348
"ISO partial datetime 2008-05-16T09 Beijing Time.\n" +
@@ -362,7 +362,7 @@ public void testSUIsoWithTimezone() throws IOException {
362362
Timex.fromXml("<TIMEX3 tid=\"t2\" value=\"2004-03-04T18:32:56-0500\" type=\"TIME\">2004-03-04T18:32:56 Eastern Standard Time</TIMEX3>"),
363363
Timex.fromXml("<TIMEX3 tid=\"t3\" value=\"T16:30\" type=\"TIME\">4:30pm</TIMEX3>"), // TODO: Mountain Time
364364
Timex.fromXml("<TIMEX3 tid=\"t4\" value=\"T09:30\" type=\"TIME\">9:30 am</TIMEX3>"),// TODO: Pacific Time
365-
Timex.fromXml("<TIMEX3 tid=\"t5\" value=\"T13:23:42-0700\" type=\"TIME\">T13:23:42 MDT</TIMEX3>"),
365+
Timex.fromXml("<TIMEX3 tid=\"t5\" value=\"T13:23:42-0700\" type=\"TIME\">T13:23:42 America/Denver</TIMEX3>"),
366366
Timex.fromXml("<TIMEX3 tid=\"t6\" value=\"2008-06-12T08:43-0800\" type=\"TIME\">8:43 PST on 6/12/2008</TIMEX3>"),
367367
Timex.fromXml("<TIMEX3 tid=\"t7\" value=\"2010-07-16T06:53:32-0800\" type=\"TIME\">6:53:32 PDT on 7-16-2010</TIMEX3>"),
368368
Timex.fromXml("<TIMEX3 tid=\"t8\" value=\"2008-05-16T09\" type=\"TIME\">2008-05-16T09</TIMEX3>"), // TODO: Beijing Time
@@ -382,7 +382,7 @@ public void testSUIsoWithTimezone() throws IOException {
382382
Timex.fromXml("<TIMEX3 tid=\"t2\" value=\"2004-03-04T18:32:56-0500\" type=\"TIME\">2004-03-04T18:32:56 Eastern Standard Time</TIMEX3>"),
383383
Timex.fromXml("<TIMEX3 tid=\"t3\" value=\"2010-02-17T16:30\" type=\"TIME\">4:30pm</TIMEX3>"), // TODO: Mountain Time
384384
Timex.fromXml("<TIMEX3 tid=\"t4\" value=\"2010-02-17T09:30\" type=\"TIME\">9:30 am</TIMEX3>"),// TODO: Pacific Time
385-
Timex.fromXml("<TIMEX3 tid=\"t5\" value=\"2010-02-17T13:23:42-0700\" type=\"TIME\">T13:23:42 MDT</TIMEX3>"),
385+
Timex.fromXml("<TIMEX3 tid=\"t5\" value=\"2010-02-17T13:23:42-0700\" type=\"TIME\">T13:23:42 America/Denver</TIMEX3>"),
386386
Timex.fromXml("<TIMEX3 tid=\"t6\" value=\"2008-06-12T08:43-0800\" type=\"TIME\">8:43 PST on 6/12/2008</TIMEX3>"),
387387
Timex.fromXml("<TIMEX3 tid=\"t7\" value=\"2010-07-16T06:53:32-0800\" type=\"TIME\">6:53:32 PDT on 7-16-2010</TIMEX3>"),
388388
Timex.fromXml("<TIMEX3 tid=\"t8\" value=\"2008-05-16T09\" type=\"TIME\">2008-05-16T09</TIMEX3>"), // TODO: Beijing Time

0 commit comments

Comments
 (0)