Skip to content

Commit 2b04504

Browse files
authored
chore: drop quibble dependency (yeoman#560)
1 parent ba03ede commit 2b04504

File tree

4 files changed

+14
-34
lines changed

4 files changed

+14
-34
lines changed

package-lock.json

+4-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-4
Original file line numberDiff line numberDiff line change
@@ -80,24 +80,23 @@
8080
"which-package-manager": "^0.0.1"
8181
},
8282
"devDependencies": {
83-
"@yeoman/eslint": "0.2.0",
8483
"@types/debug": "^4.1.9",
8584
"@types/lodash-es": "^4.17.9",
8685
"@types/semver": "^7.5.3",
86+
"@yeoman/eslint": "0.2.0",
8787
"c8": "^10.1.2",
8888
"cpy-cli": "^5.0.0",
89-
"esmocha": "^2.0.0",
89+
"eslint": "9.12.0",
90+
"esmocha": "^2.1.0",
9091
"fs-extra": "^11.1.1",
9192
"jsdoc": "^4.0.2",
9293
"prettier": "3.0.3",
9394
"prettier-plugin-packagejson": "^2.4.6",
94-
"quibble": "^0.9.1",
9595
"rimraf": "^5.0.5",
9696
"sinon": "^19.0.2",
9797
"sinon-test": "^3.1.5",
9898
"strip-ansi": "^7.1.0",
9999
"typescript": "5.2.2",
100-
"eslint": "9.12.0",
101100
"yeoman-assert": "^3.1.1",
102101
"yeoman-environment": "file:./",
103102
"yeoman-generator-2": "npm:yeoman-generator@^2.0.5",

test/generator-features.js

+4-14
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,12 @@
11
import assert from 'node:assert';
2-
import { Module } from 'node:module';
32
import sinon from 'sinon';
43
import { after, afterEach, before, beforeEach, describe, esmocha, expect, it } from 'esmocha';
5-
import quibble from 'quibble';
64
import helpers, { getCreateEnv as getCreateEnvironment } from './helpers.js';
75
import { greaterThan5 } from './generator-versions.js';
8-
import * as execaModule from 'execa';
96

10-
if (!Module.register) {
11-
throw new Error('Node greater than v18.19.0 or v20.6.0 is required to test this module.');
12-
}
13-
14-
const commitSharedFsTask = esmocha.fn();
15-
const packageManagerInstallTask = esmocha.fn();
16-
const execa = esmocha.fn();
17-
await quibble.esm('../src/commit.ts', { commitSharedFsTask });
18-
await quibble.esm('../src/package-manager.ts', { packageManagerInstallTask });
19-
await quibble.esm('execa', { ...execaModule, execa });
7+
const { commitSharedFsTask } = await esmocha.mock('../src/commit.js', import('../src/commit.js'));
8+
const { packageManagerInstallTask } = await esmocha.mock('../src/package-manager.js', import('../src/package-manager.js'));
9+
const { execa } = await esmocha.mock('execa', import('execa'));
2010
const { default: BasicEnvironment } = await import('../src/environment-base.js');
2111

2212
for (const generatorVersion of greaterThan5) {
@@ -28,7 +18,7 @@ for (const generatorVersion of greaterThan5) {
2818
esmocha.resetAllMocks();
2919
});
3020
after(() => {
31-
quibble.reset();
21+
esmocha.reset(true);
3222
});
3323

3424
describe('customCommitTask feature', () => {

test/package-manager.js

+3-11
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,10 @@
1-
import { Module } from 'node:module';
21
import path, { dirname } from 'node:path';
32
import { fileURLToPath } from 'node:url';
43
import sinon from 'sinon';
54
import { after, afterEach, beforeEach, describe, esmocha, expect, it } from 'esmocha';
6-
import quibble from 'quibble';
75

8-
if (!Module.register) {
9-
throw new Error('Node greater than v18.19.0 or v20.6.0 is required to test this module.');
10-
}
11-
12-
const execa = esmocha.fn();
13-
await quibble.esm('execa', { execa });
14-
const whichPackageManager = esmocha.fn();
15-
await quibble.esm('which-package-manager', { whichPackageManager });
6+
const { execa } = await esmocha.mock('execa', import('execa'));
7+
const { whichPackageManager } = await esmocha.mock('which-package-manager', import('which-package-manager'));
168

179
const { packageManagerInstallTask } = await import('../src/package-manager.js');
1810

@@ -43,7 +35,7 @@ describe('environment (package-manager)', () => {
4335
esmocha.resetAllMocks();
4436
});
4537
after(() => {
46-
quibble.reset();
38+
esmocha.reset();
4739
});
4840

4941
describe('#packageManagerInstallTask()', () => {

0 commit comments

Comments
 (0)