Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Properties / inputs without default value show "" as default value #23

Closed
Yogu opened this issue May 23, 2022 · 2 comments · Fixed by #28
Closed

[Bug] Properties / inputs without default value show "" as default value #23

Yogu opened this issue May 23, 2022 · 2 comments · Fixed by #28
Assignees
Labels
bug Something isn't working

Comments

@Yogu
Copy link

Yogu commented May 23, 2022

If a property has no default value, the "Default" column shows "". Instead, it should somehow indicate that there is no default value, e.g. leave the cell blank.

@Yogu Yogu added the bug Something isn't working label May 23, 2022
@Etienne-Buschong
Copy link
Collaborator

Etienne-Buschong commented May 23, 2022

I will need to double check what we actually write in the defaultField in such cases ("" or undefined). It may be possible that this out of the scope of this plugin, since we use the ArgsTable-react-component to render the types (which is not part of this repo).

@Etienne-Buschong Etienne-Buschong self-assigned this May 31, 2022
@Etienne-Buschong
Copy link
Collaborator

I just checked it again. The ArgsTable requires that a string is entered, so this is nothing that we can change on our side.
Would it be an okay-ish solution to explicitly write something like "No default value", or would this be too verbose?

@Etienne-Buschong Etienne-Buschong linked a pull request Jun 7, 2022 that will close this issue
@Etienne-Buschong Etienne-Buschong removed a link to a pull request Jun 9, 2022
@Etienne-Buschong Etienne-Buschong linked a pull request Jun 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants