Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path-prefix to types #4

Closed
kroeder opened this issue Mar 14, 2022 · 1 comment
Closed

Add path-prefix to types #4

kroeder opened this issue Mar 14, 2022 · 1 comment
Assignees
@Etienne-Buschong
Labels
bug Something isn't working

Comments

@kroeder
Copy link
Member

kroeder commented Mar 14, 2022

Right now, if you have the same Identifier (e.g. TestComponent) in two files, you don't create two global type objects but instead overwrite the first one.

Adding the file-path as prefix to the type fixes this
@kroeder kroeder added the bug Something isn't working label Mar 14, 2022
@Etienne-Buschong Etienne-Buschong self-assigned this Mar 16, 2022
@Etienne-Buschong
Copy link
Collaborator

Fixed in #6 via global unique counter suffix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Etienne-Buschong Etienne-Buschong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kroeder @Etienne-Buschong