breaking: remove allowSatisfies option, always parsed now

Author: dummdidumm

CHANGELOG.md

@@ -14,5 +14,7 @@ Version 1.0 of `@sveltejs/acorn-typescript` has some breaking changes compared t
 
 - Only named export (i.e. you have to do `import { tsPlugin } from '@sveltejs/acorn-typescript';`, a default export is no longer provided)
 - ESM only (no CJS build)
+- JSX parsing is disabled by default now (you can turn it back on by passing `{ jsx: true }`)
+- `allowSatisfies` option was removed, `satisfies` operator is always parsed now
 
 Changelog of the project this originated from: https://github.com/TyrealHu/acorn-typescript/CHANGELOG.md

__test__/satisfies/index.test.ts

@@ -1,15 +1,11 @@
 import { describe, it } from 'vitest';
-import { equalNode, parseSourceAllowSatisfies, parseSourceShouldThrowError } from '../utils';
+import { equalNode, parseSource } from '../utils';
 import SatisfiesSnapshot from '../__snapshot__/satisfies';
 
 describe('satisfies', function () {
 	it('normal', function () {
-		const node = parseSourceAllowSatisfies('const a = 1 satisfies any');
+		const node = parseSource('const a = 1 satisfies any');
 
 		equalNode(node, SatisfiesSnapshot.Normal);
 	});
-
-	it('should error', function () {
-		parseSourceShouldThrowError('const a = 1 satisfies any', 'Unexpected token (1:12)');
-	});
 });

__test__/utils.ts

@@ -16,12 +16,6 @@ export const JsxParser = acorn.Parser.extend(
 	})
 );
 
-export const AllowSatisfiesParser = acorn.Parser.extend(
-	tsPlugin({
-		allowSatisfies: true
-	})
-);
-
 export function equalNode(node, snapshot) {
 	assert.deepEqual(JSON.parse(JSON.stringify(node)), snapshot, 'should be' + JSON.stringify(node));
 }
@@ -50,14 +44,6 @@ export function parseSource(input: string) {
 	});
 }
 
-export function parseSourceAllowSatisfies(input: string) {
-	return AllowSatisfiesParser.parse(input, {
-		sourceType: 'module',
-		ecmaVersion: 'latest',
-		locations: true
-	});
-}
-
 export function parseSourceShouldThrowError(input: string, message?: string) {
 	try {
 		Parser.parse(input, {

index.d.ts

@@ -2,7 +2,6 @@ import { Parser } from 'acorn';
 
 export function tsPlugin(options?: {
 	dts?: boolean;
-	allowSatisfies?: boolean;
 	/** Whether to use JSX. Defaults to false */
 	jsx?:
 		| boolean

src/index.ts

@@ -150,9 +150,8 @@ export function tsPlugin(options?: {
 				allowNamespaces?: boolean;
 				allowNamespacedObjects?: boolean;
 		  };
-	allowSatisfies?: boolean;
 }) {
-	const { dts = false, allowSatisfies = false } = options || {};
+	const { dts = false } = options || {};
 	const disallowAmbiguousJSXLike = !!options?.jsx;
 
 	return function (Parser: typeof AcornParseClass) {
@@ -2897,7 +2896,7 @@ export function tsPlugin(options?: {
 						nodeType = 'TSAsExpression';
 					}
 
-					if (allowSatisfies && this.isContextual('satisfies')) {
+					if (this.isContextual('satisfies')) {
 						nodeType = 'TSSatisfiesExpression';
 					}
 

tsconfig.json

@@ -14,6 +14,6 @@
 		"sourceMap": true,
 		"strict": false
 	},
-	"include": ["./src/*", "./__test__/*"],
-	"exclude": ["./__test__/__snapshots__/*"]
+	"include": ["./src/**/*", "./__test__/**/*"],
+	"exclude": ["./__test__/__snapshots__/**/*"]
 }