Improve 'sync_db_pools' codegen. Update UI tests.

Author: SergioBenitez

contrib/db_pools/codegen/tests/ui-fail-stable/database-syntax.stderr

@@ -1,109 +1,115 @@
 error: invalid value: expected string literal
- --> $DIR/database-syntax.rs:4:12
+ --> tests/ui-fail-stable/database-syntax.rs:4:12
   |
 4 | #[database(123)]
   |            ^^^
 
 error: [note] error occurred while deriving `Database`
- --> $DIR/database-syntax.rs:3:10
+ --> tests/ui-fail-stable/database-syntax.rs:3:10
   |
 3 | #[derive(Database)]
   |          ^^^^^^^^
   |
   = note: this error originates in the derive macro `Database` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: expected key/value `key = value`
- --> $DIR/database-syntax.rs:8:25
+ --> tests/ui-fail-stable/database-syntax.rs:8:25
   |
 8 | #[database("some-name", "another")]
   |                         ^^^^^^^^^
 
 error: [note] error occurred while deriving `Database`
- --> $DIR/database-syntax.rs:7:10
+ --> tests/ui-fail-stable/database-syntax.rs:7:10
   |
 7 | #[derive(Database)]
   |          ^^^^^^^^
   |
   = note: this error originates in the derive macro `Database` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: unexpected attribute parameter: `name`
-  --> $DIR/database-syntax.rs:12:25
+  --> tests/ui-fail-stable/database-syntax.rs:12:25
    |
 12 | #[database("some-name", name = "another")]
-   |                         ^^^^
+   |                         ^^^^^^^^^^^^^^^^
 
 error: [note] error occurred while deriving `Database`
-  --> $DIR/database-syntax.rs:11:10
+  --> tests/ui-fail-stable/database-syntax.rs:11:10
    |
 11 | #[derive(Database)]
    |          ^^^^^^^^
    |
    = note: this error originates in the derive macro `Database` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: enums are not supported
-  --> $DIR/database-syntax.rs:16:1
+  --> tests/ui-fail-stable/database-syntax.rs:16:1
    |
-16 | #[database("foo")]
-   | ^
+16 | / #[database("foo")]
+17 | | enum D {  }
+   | |___________^
 
 error: [note] error occurred while deriving `Database`
-  --> $DIR/database-syntax.rs:15:10
+  --> tests/ui-fail-stable/database-syntax.rs:15:10
    |
 15 | #[derive(Database)]
    |          ^^^^^^^^
    |
    = note: this error originates in the derive macro `Database` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: missing `#[database("name")]` attribute
-  --> $DIR/database-syntax.rs:20:1
+  --> tests/ui-fail-stable/database-syntax.rs:20:1
    |
 20 | struct E(deadpool_postgres::Pool);
-   | ^^^^^^
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: [note] error occurred while deriving `Database`
-  --> $DIR/database-syntax.rs:19:10
+  --> tests/ui-fail-stable/database-syntax.rs:19:10
    |
 19 | #[derive(Database)]
    |          ^^^^^^^^
    |
    = note: this error originates in the derive macro `Database` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: struct must have exactly one unnamed field
-  --> $DIR/database-syntax.rs:23:1
+  --> tests/ui-fail-stable/database-syntax.rs:23:1
    |
-23 | #[database("foo")]
-   | ^
+23 | / #[database("foo")]
+24 | | struct F;
+   | |_________^
 
 error: [note] error occurred while deriving `Database`
-  --> $DIR/database-syntax.rs:22:10
+  --> tests/ui-fail-stable/database-syntax.rs:22:10
    |
 22 | #[derive(Database)]
    |          ^^^^^^^^
    |
    = note: this error originates in the derive macro `Database` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: struct must have exactly one unnamed field
-  --> $DIR/database-syntax.rs:27:1
+  --> tests/ui-fail-stable/database-syntax.rs:27:1
    |
-27 | #[database("foo")]
-   | ^
+27 | / #[database("foo")]
+28 | | struct G(deadpool_postgres::Pool, deadpool_postgres::Pool);
+   | |___________________________________________________________^
 
 error: [note] error occurred while deriving `Database`
-  --> $DIR/database-syntax.rs:26:10
+  --> tests/ui-fail-stable/database-syntax.rs:26:10
    |
 26 | #[derive(Database)]
    |          ^^^^^^^^
    |
    = note: this error originates in the derive macro `Database` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: named structs are not supported
-  --> $DIR/database-syntax.rs:31:1
+  --> tests/ui-fail-stable/database-syntax.rs:31:1
    |
-31 | #[database("foo")]
-   | ^
+31 | / #[database("foo")]
+32 | | struct H {
+33 | |     foo: deadpool_postgres::Pool,
+34 | | }
+   | |_^
 
 error: [note] error occurred while deriving `Database`
-  --> $DIR/database-syntax.rs:30:10
+  --> tests/ui-fail-stable/database-syntax.rs:30:10
    |
 30 | #[derive(Database)]
    |          ^^^^^^^^

contrib/sync_db_pools/codegen/src/database.rs

@@ -73,15 +73,16 @@ pub fn database_attr(attr: TokenStream, input: TokenStream) -> Result<TokenStrea
     let rocket = quote!(#root::rocket);
 
     let request_guard_type = quote_spanned! { span =>
-        #(#attrs)* #vis struct #guard_type(#root::Connection<Self, #conn_type>);
+        #(#attrs)* #vis struct #guard_type(#[allow(dead_code)] #root::Connection<Self, #conn_type>);
     };
 
     let pool = quote_spanned!(span => #root::ConnectionPool<Self, #conn_type>);
     let conn = quote_spanned!(span => #root::Connection<Self, #conn_type>);
 
-    Ok(quote! {
+    Ok(quote_spanned! { span =>
         #request_guard_type
 
+        #[allow(dead_code)]
         impl #guard_type {
             /// Returns a fairing that initializes the database connection pool.
             pub fn fairing() -> impl #rocket::fairing::Fairing {