Skip to content
This repository was archived by the owner on Apr 17, 2024. It is now read-only.

Commit be58924

Browse files
LizaTretyakovacopybara-github
authored andcommitted
Move Ed25519ProtoSerialization and AesCtrHmacStreamingProtoSerialization into internal/ and make it public for the use in test for future ConfigurationV0.
PiperOrigin-RevId: 615017125
1 parent 64453ab commit be58924

15 files changed

+190
-177
lines changed

java_src/BUILD.bazel

+4-4
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ gen_maven_jar_rules(
342342
"//src/main/java/com/google/crypto/tink/signature:ed25519_parameters",
343343
"//src/main/java/com/google/crypto/tink/signature:ed25519_private_key",
344344
"//src/main/java/com/google/crypto/tink/signature:ed25519_private_key_manager",
345-
"//src/main/java/com/google/crypto/tink/signature:ed25519_proto_serialization",
346345
"//src/main/java/com/google/crypto/tink/signature:ed25519_public_key",
347346
"//src/main/java/com/google/crypto/tink/signature:ed25519_public_key_manager",
348347
"//src/main/java/com/google/crypto/tink/signature:predefined_signature_parameters",
@@ -369,6 +368,7 @@ gen_maven_jar_rules(
369368
"//src/main/java/com/google/crypto/tink/signature:signature_private_key",
370369
"//src/main/java/com/google/crypto/tink/signature:signature_public_key",
371370
"//src/main/java/com/google/crypto/tink/signature/internal:ecdsa_proto_serialization",
371+
"//src/main/java/com/google/crypto/tink/signature/internal:ed25519_proto_serialization",
372372
"//src/main/java/com/google/crypto/tink/signature/internal:legacy_full_sign",
373373
"//src/main/java/com/google/crypto/tink/signature/internal:legacy_full_verify",
374374
"//src/main/java/com/google/crypto/tink/signature/internal:rsa_ssa_pkcs1_proto_serialization",
@@ -377,7 +377,6 @@ gen_maven_jar_rules(
377377
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_key",
378378
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_key_manager",
379379
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_parameters",
380-
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_proto_serialization",
381380
"//src/main/java/com/google/crypto/tink/streamingaead:aes_gcm_hkdf_streaming_key",
382381
"//src/main/java/com/google/crypto/tink/streamingaead:aes_gcm_hkdf_streaming_key_manager",
383382
"//src/main/java/com/google/crypto/tink/streamingaead:aes_gcm_hkdf_streaming_parameters",
@@ -393,6 +392,7 @@ gen_maven_jar_rules(
393392
"//src/main/java/com/google/crypto/tink/streamingaead:streaming_aead_parameters",
394393
"//src/main/java/com/google/crypto/tink/streamingaead:streaming_aead_util",
395394
"//src/main/java/com/google/crypto/tink/streamingaead:streaming_aead_wrapper",
395+
"//src/main/java/com/google/crypto/tink/streamingaead/internal:aes_ctr_hmac_streaming_proto_serialization",
396396
"//src/main/java/com/google/crypto/tink/streamingaead/internal:aes_gcm_hkdf_streaming_proto_serialization",
397397
"//src/main/java/com/google/crypto/tink/streamingaead/internal:legacy_full_streaming_aead",
398398
"//src/main/java/com/google/crypto/tink/subtle:aes_ctr_hmac_streaming",
@@ -799,7 +799,6 @@ gen_maven_jar_rules(
799799
"//src/main/java/com/google/crypto/tink/signature:ed25519_parameters-android",
800800
"//src/main/java/com/google/crypto/tink/signature:ed25519_private_key-android",
801801
"//src/main/java/com/google/crypto/tink/signature:ed25519_private_key_manager-android",
802-
"//src/main/java/com/google/crypto/tink/signature:ed25519_proto_serialization-android",
803802
"//src/main/java/com/google/crypto/tink/signature:ed25519_public_key-android",
804803
"//src/main/java/com/google/crypto/tink/signature:ed25519_public_key_manager-android",
805804
"//src/main/java/com/google/crypto/tink/signature:predefined_signature_parameters-android",
@@ -826,6 +825,7 @@ gen_maven_jar_rules(
826825
"//src/main/java/com/google/crypto/tink/signature:signature_private_key-android",
827826
"//src/main/java/com/google/crypto/tink/signature:signature_public_key-android",
828827
"//src/main/java/com/google/crypto/tink/signature/internal:ecdsa_proto_serialization-android",
828+
"//src/main/java/com/google/crypto/tink/signature/internal:ed25519_proto_serialization-android",
829829
"//src/main/java/com/google/crypto/tink/signature/internal:legacy_full_sign-android",
830830
"//src/main/java/com/google/crypto/tink/signature/internal:legacy_full_verify-android",
831831
"//src/main/java/com/google/crypto/tink/signature/internal:rsa_ssa_pkcs1_proto_serialization-android",
@@ -834,7 +834,6 @@ gen_maven_jar_rules(
834834
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_key-android",
835835
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_key_manager-android",
836836
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_parameters-android",
837-
"//src/main/java/com/google/crypto/tink/streamingaead:aes_ctr_hmac_streaming_proto_serialization-android",
838837
"//src/main/java/com/google/crypto/tink/streamingaead:aes_gcm_hkdf_streaming_key-android",
839838
"//src/main/java/com/google/crypto/tink/streamingaead:aes_gcm_hkdf_streaming_key_manager-android",
840839
"//src/main/java/com/google/crypto/tink/streamingaead:aes_gcm_hkdf_streaming_parameters-android",
@@ -850,6 +849,7 @@ gen_maven_jar_rules(
850849
"//src/main/java/com/google/crypto/tink/streamingaead:streaming_aead_parameters-android",
851850
"//src/main/java/com/google/crypto/tink/streamingaead:streaming_aead_util-android",
852851
"//src/main/java/com/google/crypto/tink/streamingaead:streaming_aead_wrapper-android",
852+
"//src/main/java/com/google/crypto/tink/streamingaead/internal:aes_ctr_hmac_streaming_proto_serialization-android",
853853
"//src/main/java/com/google/crypto/tink/streamingaead/internal:aes_gcm_hkdf_streaming_proto_serialization-android",
854854
"//src/main/java/com/google/crypto/tink/streamingaead/internal:legacy_full_streaming_aead-android",
855855
"//src/main/java/com/google/crypto/tink/subtle:aes_ctr_hmac_streaming-android",

java_src/src/main/java/com/google/crypto/tink/signature/BUILD.bazel

+2-56
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,6 @@ java_library(
247247
deps = [
248248
":ed25519_parameters",
249249
":ed25519_private_key",
250-
":ed25519_proto_serialization",
251250
":ed25519_public_key",
252251
":ed25519_public_key_manager",
253252
"//proto:ed25519_java_proto",
@@ -271,6 +270,7 @@ java_library(
271270
"//src/main/java/com/google/crypto/tink/internal:primitive_constructor",
272271
"//src/main/java/com/google/crypto/tink/internal:tink_bug_exception",
273272
"//src/main/java/com/google/crypto/tink/internal:util",
273+
"//src/main/java/com/google/crypto/tink/signature/internal:ed25519_proto_serialization",
274274
"//src/main/java/com/google/crypto/tink/subtle:ed25519_sign",
275275
"//src/main/java/com/google/crypto/tink/subtle:ed25519_verify",
276276
"//src/main/java/com/google/crypto/tink/util:bytes",
@@ -453,33 +453,6 @@ java_library(
453453
],
454454
)
455455

456-
java_library(
457-
name = "ed25519_proto_serialization",
458-
srcs = ["Ed25519ProtoSerialization.java"],
459-
deps = [
460-
":ed25519_parameters",
461-
":ed25519_private_key",
462-
":ed25519_public_key",
463-
"//proto:ed25519_java_proto",
464-
"//proto:tink_java_proto",
465-
"//src/main/java/com/google/crypto/tink:accesses_partial_key",
466-
"//src/main/java/com/google/crypto/tink:secret_key_access",
467-
"//src/main/java/com/google/crypto/tink/internal:enum_type_proto_converter",
468-
"//src/main/java/com/google/crypto/tink/internal:key_parser",
469-
"//src/main/java/com/google/crypto/tink/internal:key_serializer",
470-
"//src/main/java/com/google/crypto/tink/internal:mutable_serialization_registry",
471-
"//src/main/java/com/google/crypto/tink/internal:parameters_parser",
472-
"//src/main/java/com/google/crypto/tink/internal:parameters_serializer",
473-
"//src/main/java/com/google/crypto/tink/internal:proto_key_serialization",
474-
"//src/main/java/com/google/crypto/tink/internal:proto_parameters_serialization",
475-
"//src/main/java/com/google/crypto/tink/internal:util",
476-
"//src/main/java/com/google/crypto/tink/util:bytes",
477-
"//src/main/java/com/google/crypto/tink/util:secret_bytes",
478-
"@maven//:com_google_code_findbugs_jsr305",
479-
"@maven//:com_google_protobuf_protobuf_java",
480-
],
481-
)
482-
483456
java_library(
484457
name = "rsa_ssa_pss_parameters",
485458
srcs = ["RsaSsaPssParameters.java"],
@@ -765,7 +738,6 @@ android_library(
765738
deps = [
766739
":ed25519_parameters-android",
767740
":ed25519_private_key-android",
768-
":ed25519_proto_serialization-android",
769741
":ed25519_public_key-android",
770742
":ed25519_public_key_manager-android",
771743
"//proto:ed25519_java_proto_lite",
@@ -789,6 +761,7 @@ android_library(
789761
"//src/main/java/com/google/crypto/tink/internal:primitive_constructor-android",
790762
"//src/main/java/com/google/crypto/tink/internal:tink_bug_exception-android",
791763
"//src/main/java/com/google/crypto/tink/internal:util-android",
764+
"//src/main/java/com/google/crypto/tink/signature/internal:ed25519_proto_serialization-android",
792765
"//src/main/java/com/google/crypto/tink/subtle:ed25519_sign-android",
793766
"//src/main/java/com/google/crypto/tink/subtle:ed25519_verify-android",
794767
"//src/main/java/com/google/crypto/tink/util:bytes-android",
@@ -971,33 +944,6 @@ android_library(
971944
],
972945
)
973946

974-
android_library(
975-
name = "ed25519_proto_serialization-android",
976-
srcs = ["Ed25519ProtoSerialization.java"],
977-
deps = [
978-
":ed25519_parameters-android",
979-
":ed25519_private_key-android",
980-
":ed25519_public_key-android",
981-
"//proto:ed25519_java_proto_lite",
982-
"//proto:tink_java_proto_lite",
983-
"//src/main/java/com/google/crypto/tink:accesses_partial_key-android",
984-
"//src/main/java/com/google/crypto/tink:secret_key_access-android",
985-
"//src/main/java/com/google/crypto/tink/internal:enum_type_proto_converter-android",
986-
"//src/main/java/com/google/crypto/tink/internal:key_parser-android",
987-
"//src/main/java/com/google/crypto/tink/internal:key_serializer-android",
988-
"//src/main/java/com/google/crypto/tink/internal:mutable_serialization_registry-android",
989-
"//src/main/java/com/google/crypto/tink/internal:parameters_parser-android",
990-
"//src/main/java/com/google/crypto/tink/internal:parameters_serializer-android",
991-
"//src/main/java/com/google/crypto/tink/internal:proto_key_serialization-android",
992-
"//src/main/java/com/google/crypto/tink/internal:proto_parameters_serialization-android",
993-
"//src/main/java/com/google/crypto/tink/internal:util-android",
994-
"//src/main/java/com/google/crypto/tink/util:bytes-android",
995-
"//src/main/java/com/google/crypto/tink/util:secret_bytes-android",
996-
"@maven//:com_google_code_findbugs_jsr305",
997-
"@maven//:com_google_protobuf_protobuf_javalite",
998-
],
999-
)
1000-
1001947
android_library(
1002948
name = "rsa_ssa_pss_parameters-android",
1003949
srcs = ["RsaSsaPssParameters.java"],

java_src/src/main/java/com/google/crypto/tink/signature/Ed25519PrivateKeyManager.java

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import com.google.crypto.tink.internal.PrimitiveConstructor;
3838
import com.google.crypto.tink.internal.Util;
3939
import com.google.crypto.tink.proto.KeyData.KeyMaterialType;
40+
import com.google.crypto.tink.signature.internal.Ed25519ProtoSerialization;
4041
import com.google.crypto.tink.subtle.Ed25519Sign;
4142
import com.google.crypto.tink.subtle.Ed25519Verify;
4243
import com.google.crypto.tink.util.Bytes;

java_src/src/main/java/com/google/crypto/tink/signature/internal/BUILD.bazel

+54
Original file line numberDiff line numberDiff line change
@@ -263,3 +263,57 @@ android_library(
263263
"@maven//:com_google_protobuf_protobuf_javalite",
264264
],
265265
)
266+
267+
android_library(
268+
name = "ed25519_proto_serialization-android",
269+
srcs = ["Ed25519ProtoSerialization.java"],
270+
deps = [
271+
"//proto:ed25519_java_proto_lite",
272+
"//proto:tink_java_proto_lite",
273+
"//src/main/java/com/google/crypto/tink:accesses_partial_key-android",
274+
"//src/main/java/com/google/crypto/tink:secret_key_access-android",
275+
"//src/main/java/com/google/crypto/tink/internal:enum_type_proto_converter-android",
276+
"//src/main/java/com/google/crypto/tink/internal:key_parser-android",
277+
"//src/main/java/com/google/crypto/tink/internal:key_serializer-android",
278+
"//src/main/java/com/google/crypto/tink/internal:mutable_serialization_registry-android",
279+
"//src/main/java/com/google/crypto/tink/internal:parameters_parser-android",
280+
"//src/main/java/com/google/crypto/tink/internal:parameters_serializer-android",
281+
"//src/main/java/com/google/crypto/tink/internal:proto_key_serialization-android",
282+
"//src/main/java/com/google/crypto/tink/internal:proto_parameters_serialization-android",
283+
"//src/main/java/com/google/crypto/tink/internal:util-android",
284+
"//src/main/java/com/google/crypto/tink/signature:ed25519_parameters-android",
285+
"//src/main/java/com/google/crypto/tink/signature:ed25519_private_key-android",
286+
"//src/main/java/com/google/crypto/tink/signature:ed25519_public_key-android",
287+
"//src/main/java/com/google/crypto/tink/util:bytes-android",
288+
"//src/main/java/com/google/crypto/tink/util:secret_bytes-android",
289+
"@maven//:com_google_code_findbugs_jsr305",
290+
"@maven//:com_google_protobuf_protobuf_javalite",
291+
],
292+
)
293+
294+
java_library(
295+
name = "ed25519_proto_serialization",
296+
srcs = ["Ed25519ProtoSerialization.java"],
297+
deps = [
298+
"//proto:ed25519_java_proto",
299+
"//proto:tink_java_proto",
300+
"//src/main/java/com/google/crypto/tink:accesses_partial_key",
301+
"//src/main/java/com/google/crypto/tink:secret_key_access",
302+
"//src/main/java/com/google/crypto/tink/internal:enum_type_proto_converter",
303+
"//src/main/java/com/google/crypto/tink/internal:key_parser",
304+
"//src/main/java/com/google/crypto/tink/internal:key_serializer",
305+
"//src/main/java/com/google/crypto/tink/internal:mutable_serialization_registry",
306+
"//src/main/java/com/google/crypto/tink/internal:parameters_parser",
307+
"//src/main/java/com/google/crypto/tink/internal:parameters_serializer",
308+
"//src/main/java/com/google/crypto/tink/internal:proto_key_serialization",
309+
"//src/main/java/com/google/crypto/tink/internal:proto_parameters_serialization",
310+
"//src/main/java/com/google/crypto/tink/internal:util",
311+
"//src/main/java/com/google/crypto/tink/signature:ed25519_parameters",
312+
"//src/main/java/com/google/crypto/tink/signature:ed25519_private_key",
313+
"//src/main/java/com/google/crypto/tink/signature:ed25519_public_key",
314+
"//src/main/java/com/google/crypto/tink/util:bytes",
315+
"//src/main/java/com/google/crypto/tink/util:secret_bytes",
316+
"@maven//:com_google_code_findbugs_jsr305",
317+
"@maven//:com_google_protobuf_protobuf_java",
318+
],
319+
)

java_src/src/main/java/com/google/crypto/tink/signature/Ed25519ProtoSerialization.java java_src/src/main/java/com/google/crypto/tink/signature/internal/Ed25519ProtoSerialization.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
//
1515
////////////////////////////////////////////////////////////////////////////////
1616

17-
package com.google.crypto.tink.signature;
17+
package com.google.crypto.tink.signature.internal;
1818

1919
import static com.google.crypto.tink.internal.Util.toBytesFromPrintableAscii;
2020

@@ -32,6 +32,9 @@
3232
import com.google.crypto.tink.proto.KeyData.KeyMaterialType;
3333
import com.google.crypto.tink.proto.KeyTemplate;
3434
import com.google.crypto.tink.proto.OutputPrefixType;
35+
import com.google.crypto.tink.signature.Ed25519Parameters;
36+
import com.google.crypto.tink.signature.Ed25519PrivateKey;
37+
import com.google.crypto.tink.signature.Ed25519PublicKey;
3538
import com.google.crypto.tink.util.Bytes;
3639
import com.google.crypto.tink.util.SecretBytes;
3740
import com.google.protobuf.ByteString;
@@ -46,7 +49,7 @@
4649
*/
4750
@AccessesPartialKey
4851
@SuppressWarnings("UnnecessarilyFullyQualified") // Fully specifying proto types is more readable
49-
final class Ed25519ProtoSerialization {
52+
public final class Ed25519ProtoSerialization {
5053
private static final String PRIVATE_TYPE_URL =
5154
"type.googleapis.com/google.crypto.tink.Ed25519PrivateKey";
5255
private static final Bytes PRIVATE_TYPE_URL_BYTES = toBytesFromPrintableAscii(PRIVATE_TYPE_URL);

java_src/src/main/java/com/google/crypto/tink/streamingaead/AesCtrHmacStreamingKeyManager.java

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import com.google.crypto.tink.internal.MutablePrimitiveRegistry;
3232
import com.google.crypto.tink.internal.PrimitiveConstructor;
3333
import com.google.crypto.tink.proto.KeyData.KeyMaterialType;
34+
import com.google.crypto.tink.streamingaead.internal.AesCtrHmacStreamingProtoSerialization;
3435
import com.google.crypto.tink.subtle.AesCtrHmacStreaming;
3536
import com.google.crypto.tink.util.SecretBytes;
3637
import java.security.GeneralSecurityException;

0 commit comments

Comments
 (0)