Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trino Iceberg RestCatalog loadTable w/o using IRC metric reporter #25303

Open
puchengy opened this issue Mar 13, 2025 · 3 comments · May be fixed by #25331
Open

Trino Iceberg RestCatalog loadTable w/o using IRC metric reporter #25303

puchengy opened this issue Mar 13, 2025 · 3 comments · May be fixed by #25331
Labels
iceberg Iceberg connector

Comments

@puchengy
Copy link
Contributor

puchengy commented Mar 13, 2025 •
edited
Loading

trino/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoRestCatalog.java

Line 511 in 6e436e0

return new BaseTable(baseTable.operations(), quotedTableName(schemaTableName));

In Trino IRC catalog, when loading table, it recreates BaseTable w/o providing reporter instance, causing BaseTable using default reporter (logging reporter) hence causing it not report scan/ commit report data to IRC.

Not sure if this is the right approach, please recommend right way to resolve the issue.

cc: @danielcweeks
@puchengy puchengy added bug Something isn't working iceberg Iceberg connector labels Mar 13, 2025
@puchengy puchengy mentioned this issue Mar 13, 2025
Closed
3 tasks
@nastra
Copy link
Contributor

nastra commented Mar 13, 2025

I think the only viable options are apache/iceberg#12513 or using reflection to get access to the current metrics reporter

@puchengy puchengy mentioned this issue Mar 13, 2025
Merged
@ebyhr ebyhr removed the bug Something isn't working label Mar 14, 2025
@puchengy
Copy link
Contributor Author

puchengy commented Mar 15, 2025 •
edited
Loading

This ticket is currently blocked by Iceberg release of apache/iceberg#12513.

@ebyhr ebyhr linked a pull request Mar 16, 2025 that will close this issue
Draft
@ebyhr
Copy link
Member

ebyhr commented Mar 17, 2025

#25331 includes the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iceberg Iceberg connector
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Iceberg to 1.9.0 trinodb/trino
3 participants
@nastra @ebyhr @puchengy