Skip to content

Commit b6dd395

Browse files
authored
Merge pull request #599 from turnitin/prefix_all_styles
Prefix all styles
2 parents c437f25 + a47e989 commit b6dd395

40 files changed

+4827
-2475
lines changed

classes/digitalreceipt/instructor_message.php

+1-6
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,7 @@ public function send_instructor_message($instructors, $message, $courseid) {
5353

5454
$subject = get_string('receipt_instructor_copy_subject', 'turnitintooltwo');
5555

56-
// Pre 2.9 does not have \core\message\message()
57-
if ($CFG->branch >= 29) {
58-
$eventdata = new \core\message\message();
59-
} else {
60-
$eventdata = new stdClass();
61-
}
56+
$eventdata = new \core\message\message();
6257

6358
$eventdata->component = 'mod_turnitintooltwo';
6459
$eventdata->name = 'notify_instructor_of_submission'; // This is the message name from messages.php.

classes/digitalreceipt/receipt_message.php

+1-6
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,7 @@ public function send_message($userid, $message, $courseid) {
2929

3030
$subject = get_string('digital_receipt_subject', 'turnitintooltwo');
3131

32-
// Pre 2.9 does not have \core\message\message()
33-
if ($CFG->branch >= 29) {
34-
$eventdata = new \core\message\message();
35-
} else {
36-
$eventdata = new stdClass();
37-
}
32+
$eventdata = new \core\message\message();
3833

3934
$eventdata->component = 'mod_turnitintooltwo';
4035
$eventdata->name = 'submission'; // This is the message name from messages.php.

classes/v1migration/v1migration.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ private function log_success_migration_event($turnitintooltwoid, $course_id, $v1
545545
}
546546

547547
/**
548-
* Get assignments for migrated data table. Called from ajax.php via turnitintooltwo_extra-2018102601.min.js.
548+
* Get assignments for migrated data table. Called from ajax.php via turnitintooltwo_extra-2020111101.min.js.
549549
*
550550
* @global type $DB
551551
* @return array return array of assignments to display

classes/view/members.php

+3-4
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,17 @@ public function __construct($course=null, $coursemodule=null, $turnitintooltwovi
4141
* @return string Members HTML for a role
4242
*/
4343
public function build_members_view($displayrole = "students") {
44-
$output = "";
4544
$istutor = $this->is_tutor();
4645

4746
if (!$istutor) {
4847
turnitintooltwo_print_error('permissiondeniederror', 'turnitintooltwo');
4948
exit();
5049
}
5150

52-
$wrapperclass = $displayrole == "tutors" ? "members members-instructors" : "members members-students";
51+
$wrapperclass = $displayrole == "tutors" ? "members-instructors" : "members-students";
5352

54-
// wrapper element for strong CSS selectors
55-
$output .= html_writer::start_tag("div", array("class" => $wrapperclass));
53+
// Wrapper element for strong CSS selectors.
54+
$output = html_writer::start_tag("div", array("class" => "mod_turnitintooltwo_members " . $wrapperclass));
5655

5756
$output .= $this->build_intro_message($displayrole);
5857
$output .= $this->build_members_table($displayrole);

css/student_noscript.css

+9-14
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,28 @@
1-
.mod_turnitintooltwo .submissionsDataTable {
1+
.mod_turnitintooltwo_submissions_data_table {
22
margin-top:16px;
33
}
44

5-
.mod_turnitintooltwo .submissionsDataTable th {
5+
.mod_turnitintooltwo_submissions_data_table th {
66
border:1px solid #999999;
77
}
88

9-
.mod_turnitintooltwo .submissionsDataTable td {
9+
.mod_turnitintooltwo_submissions_data_table td {
1010
border:1px solid #999999;
1111
}
1212

13-
.mod_turnitintooltwo #tabs ul#part_tabs_menu, .mod_turnitintooltwo a.toggle_summary, .mod_turnitintooltwo a.toggle_peermarks,
14-
.mod_turnitintooltwo a.toggle_peermark_instructions, .mod_turnitintooltwo .turnitin_ula, .mod_turnitintooltwo a.messages_inbox,
15-
.mod_turnitintooltwo .noscript_hide, .mod_turnitintooltwo .download_original_open, .mod_turnitintooltwo th.raw_data,
16-
.mod_turnitintooltwo td.raw_data, .mod_turnitintooltwo .submissionsDataTable th.cpart,
17-
.mod_turnitintooltwo .submissionsDataTable th.ccheckbox, .mod_turnitintooltwo .submissionsDataTable td.c0,
18-
.mod_turnitintooltwo .submissionsDataTable td.c1 {
13+
.mod_turnitintooltwo #tabs ul#part_tabs_menu, .mod_turnitintooltwo a.toggle_summary, .mod_turnitintooltwo a.toggle_peermarks,
14+
.mod_turnitintooltwo a.toggle_peermark_instructions, .mod_turnitintooltwo .mod_turnitintooltwo_eula, .mod_turnitintooltwo_messages_inbox,
15+
.mod_turnitintooltwo .noscript_hide, .mod_turnitintooltwo .download_original_open, .mod_turnitintooltwo th.raw_data,
16+
.mod_turnitintooltwo td.raw_data, .mod_turnitintooltwo_submissions_data_table th.cpart,
17+
.mod_turnitintooltwo_submissions_data_table th.ccheckbox, .mod_turnitintooltwo_submissions_data_table td.c0,
18+
.mod_turnitintooltwo_submissions_data_table td.c1 {
1919
display:none;
2020
}
2121

2222
.mod_turnitintooltwo .peermark_instructions {
2323
display: block;
2424
}
2525

26-
.mod_turnitintooltwo .turnitin_ula_noscript {
27-
line-height: 28px;
28-
margin-top:16px;
29-
}
30-
3126
.mod_turnitintooltwo .part_table {
3227
background:#EFEFEF;
3328
border:1px solid #DEDEDE;

extras.php

+2-8
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,7 @@
3939

4040
// Get course and module data that we've linked to here from and set context accordingly.
4141
if ($id != 0) {
42-
// Pre 2.8 does not have the function get_course_and_cm_from_cmid.
43-
if ($CFG->branch >= 28) {
44-
list($course, $cm) = get_course_and_cm_from_cmid($id, 'turnitintooltwo');
45-
} else {
46-
$cm = get_coursemodule_from_id('turnitintooltwo', $id, 0, false, MUST_EXIST);
47-
$course = $DB->get_record('course', array('id' => $cm->course), '*', MUST_EXIST);
48-
}
42+
list($course, $cm) = get_course_and_cm_from_cmid($id, 'turnitintooltwo');
4943

5044
if (!$cm) {
5145
turnitintooltwo_print_error('coursemodidincorrect', 'turnitintooltwo');
@@ -127,7 +121,7 @@
127121
$output .= $OUTPUT->box($categoryselectlabel." ".$categoryselect.$createassign.$createbutton, 'create_checkboxes navbar');
128122

129123
$table = new html_table();
130-
$table->id = "courseBrowserTable";
124+
$table->id = "mod_turnitintooltwo_course_browser_table";
131125
$rows = array();
132126

133127
// Make up json array for drop down in table.

gulpfile.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
var gulp = require('gulp');
22
var sass = require('gulp-sass');
33

4-
var minifyCss = require('gulp-minify-css');
4+
var minifyCss = require('gulp-clean-css');
55
var sourcemaps = require('gulp-sourcemaps');
66
var notify = require('gulp-notify');
77
var uglify = require('gulp-uglify');
@@ -30,8 +30,8 @@ gulp.task('jsmin', function() {
3030
});
3131

3232
gulp.task('watch', function() {
33-
gulp.watch('./sass/**/*.scss', ['sass']);
34-
gulp.watch('./jquery/turnitintooltwo*.js', ['jsmin']);
33+
gulp.watch('./sass/**/*.scss', gulp.series('sass'));
34+
gulp.watch('./jquery/turnitintooltwo*.js', gulp.series('jsmin'));
3535
});
3636

37-
gulp.task('default', ['sass', 'jsmin', 'watch']);
37+
gulp.task('default', gulp.series(['sass', 'jsmin', 'watch']));

jquery/plugins.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
$plugins = array(
2020
'turnitintooltwo-dataTables' => array('files' => array('jquery.dataTables.js', 'jquery.dataTables.css')),
2121
'turnitintooltwo-dataTables_plugins' => array('files' => array('jquery.dataTables.plugins.js')),
22-
'turnitintooltwo-turnitintooltwo' => array('files' => array('turnitintooltwo-2018102601.min.js')),
23-
'turnitintooltwo-turnitintooltwo_extra' => array('files' => array('turnitintooltwo_extra-2018102601.min.js')),
24-
'turnitintooltwo-turnitintooltwo_settings' => array('files' => array('turnitintooltwo_settings-2018102601.min.js')),
22+
'turnitintooltwo-turnitintooltwo' => array('files' => array('turnitintooltwo-2020111101.min.js')),
23+
'turnitintooltwo-turnitintooltwo_extra' => array('files' => array('turnitintooltwo_extra-2020111101.min.js')),
24+
'turnitintooltwo-turnitintooltwo_settings' => array('files' => array('turnitintooltwo_settings-2020111101.min.js')),
2525
'turnitintooltwo-datatables_columnfilter' => array('files' => array('jquery.dataTables.columnFilter.js')),
2626
'turnitintooltwo-cookie' => array('files' => array('jquery.cookie.js')),
2727
'turnitintooltwo-colorbox' => array('files' => array('jquery.colorbox.js', 'colorbox.css')),

jquery/turnitintooltwo-2018102601.min.js

-3
This file was deleted.

0 commit comments

Comments
 (0)