Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection test URL should use site url, and not depend on the presence DOM elements #772

Open
matthewhilton opened this issue Oct 22, 2024 · 0 comments

Comments

@matthewhilton
Copy link

matthewhilton commented Oct 22, 2024

The URL used to query the connection test:

var url = "ajax.php";
if ($('.settingsform fieldset div.formsettingheading').length > 0) {
url = "../mod/turnitintooltwo/ajax.php";
}

Currently it checks for the presence of a particular dom element to decide which URL to use. However, this is not ideal if your site has a custom theme where this DOM element does not exist because it will instead try to call /admin/ajax.php which does not exist.

It should really be using M.cfg.wwwroot instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant