Skip to content

Commit 9c23fe2

Browse files
committed
github/install.sh: prevent output pollution from package installs
Signed-off-by: Steven Noonan <[email protected]>
1 parent 30ed7ca commit 9c23fe2

File tree

2 files changed

+27
-5
lines changed

2 files changed

+27
-5
lines changed

.github/install-fedora.sh

+3-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
# This is an install script for Fedora-specific packages.
44
#
55
set -ex
6-
set -o pipefail
76

87
# Base build packages
98
PACKAGES=(
@@ -24,8 +23,8 @@ if ! grep '^fastestmirror' /etc/dnf/dnf.conf; then
2423
echo 'fastestmirror=1' >> /etc/dnf/dnf.conf
2524
fi
2625

27-
dnf clean all | cat
28-
dnf update -y | cat
29-
dnf install -y "${PACKAGES[@]}" | cat
26+
dnf clean all
27+
dnf update -y
28+
dnf install -y "${PACKAGES[@]}"
3029

3130
exit 0

.github/install.sh

+24-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,25 @@
11
#!/bin/bash
2-
. .github/install-${IMAGE//\//-}.sh
2+
3+
set -e
4+
set -o pipefail
5+
6+
INSTALL_SCRIPT_CANDIDATES=(
7+
"$PWD/.github/install-${IMAGE//\//-}.sh"
8+
"$PWD/.github/install-${IMAGE%/*}.sh"
9+
)
10+
11+
for INSTALL_SCRIPT in "${INSTALL_SCRIPT_CANDIDATES[@]}"; do
12+
if [[ -f "${INSTALL_SCRIPT}" ]]; then
13+
bash "${INSTALL_SCRIPT}" | cat
14+
exit $?
15+
fi
16+
done
17+
18+
echo "Could not find install script in any of these paths:"
19+
for INSTALL_SCRIPT in "${INSTALL_SCRIPT_CANDIDATES[@]}"; do
20+
echo " ${INSTALL_SCRIPT}"
21+
done
22+
echo ""
23+
echo "Don't know how to install packages for ${IMAGE}!"
24+
echo ""
25+
exit 1

0 commit comments

Comments
 (0)