Skip to content

Commit cdbc76b

Browse files
ndelanouueman
andauthored
feat(sentry_link): bump to sentry 8.0.0 (#13)
* bump `sentry` dependency * fix changes * fix failing test * set minimal version for `sentry` * Update sentry_link/pubspec.yaml --------- Co-authored-by: Jonas Uekötter <[email protected]>
1 parent 4438de3 commit cdbc76b

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

sentry_link/lib/src/graph_gl_filter.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import 'package:sentry/sentry.dart';
22

33
BeforeBreadcrumbCallback graphQlFilter([BeforeBreadcrumbCallback? filter]) {
44
return (
5-
Breadcrumb? ogBreadcrumb, {
6-
Hint? hint,
7-
}) {
8-
final breadCrumb = filter?.call(ogBreadcrumb, hint: hint);
5+
Breadcrumb? ogBreadcrumb,
6+
Hint hint,
7+
) {
8+
final breadCrumb = (filter != null) ? filter.call(ogBreadcrumb, hint) : ogBreadcrumb;
99
if (breadCrumb == null) {
1010
return null;
1111
}

sentry_link/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ dependencies:
1212
gql_exec: ">=0.4.0 < 2.0.0"
1313
gql_link: ">=0.5.0 < 2.0.0"
1414
gql: ">=0.14.0 < 2.0.0"
15-
sentry: ^7.8.0
15+
sentry: ^8.0.0
1616

1717
dev_dependencies:
1818
lints: ^1.0.0

sentry_link/test/graph_gl_filter.dart

+8-3
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,19 @@ import 'package:test/test.dart';
44

55
void main() {
66
test('GraphQL urls should be filtered', () {
7-
final result = graphQlFilter()(Breadcrumb.http(
8-
url: Uri.parse('https://example.org/graphql'), method: 'gte'));
7+
final result = graphQlFilter()(
8+
Breadcrumb.http(
9+
url: Uri.parse('https://example.org/graphql'), method: 'get'),
10+
Hint(),
11+
);
912
expect(result, null);
1013
});
1114

1215
test('non GraphQL urls should not be filtered', () {
1316
final result = graphQlFilter()(
14-
Breadcrumb.http(url: Uri.parse('https://example.org/'), method: 'gte'));
17+
Breadcrumb.http(url: Uri.parse('https://example.org/'), method: 'get'),
18+
Hint(),
19+
);
1520
expect(result, isNotNull);
1621
});
1722
}

0 commit comments

Comments
 (0)