Skip to content

Commit c8a388d

Browse files
authoredMar 14, 2025··
fix: change default conditions and mainFields (#238)
1 parent fbee5eb commit c8a388d

File tree

5 files changed

+20
-5
lines changed

5 files changed

+20
-5
lines changed
 

‎.changeset/silver-wombats-sit.md

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"eslint-plugin-import-x": patch
3+
---
4+
5+
fix: change default `conditions` and `mainFields`
6+
7+
`default` should be last matched, `module` should be in `mainFields`.
8+
9+
Reference https://github.com/isaacs/resolve-import/blob/03daf0a9649d183bea40975a7777ae72955f44b8/src/resolve-conditional-value.ts#L15

‎.prettierignore

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
test/fixtures/just-json-files/invalid.json
22
test/fixtures/malformed.js
33
test/fixtures/with-syntax-error/package.json
4+
CHANGELOG.md

‎.prettierrc.mjs

+6
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,11 @@ export default {
1010
parser: 'babel-flow',
1111
},
1212
},
13+
{
14+
files: ['**/.changeset/*.md'],
15+
options: {
16+
singleQuote: false,
17+
},
18+
},
1319
],
1420
}

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@
5353
"@typescript-eslint/utils": "^8.1.0",
5454
"debug": "^4.3.4",
5555
"doctrine": "^3.0.0",
56+
"enhanced-resolve": "^5.17.1",
5657
"eslint-import-resolver-node": "^0.3.9",
5758
"get-tsconfig": "^4.7.3",
5859
"is-glob": "^4.0.3",
5960
"minimatch": "^9.0.3",
60-
"enhanced-resolve": "^5.17.1",
6161
"semver": "^7.6.3",
6262
"stable-hash": "^0.0.4",
6363
"tslib": "^2.6.3"

‎src/node-resolver.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,16 @@ type NodeResolverOptions = {
2424

2525
export function createNodeResolver({
2626
extensions = ['.mjs', '.cjs', '.js', '.json', '.node'],
27-
conditionNames = ['default', 'module', 'import', 'require'],
28-
mainFields: _mainFields = ['main'],
29-
exportsFields: _exportsFields = ['exports'],
30-
mainFiles: _mainFiles = ['index'],
27+
conditionNames = ['import', 'require', 'default'],
28+
mainFields = ['module', 'main'],
3129
fileSystem = new CachedInputFileSystem(fs, 4 * 1000),
3230
...restOptions
3331
}: Partial<NodeResolverOptions> = {}): NewResolver {
3432
const resolver = ResolverFactory.createResolver({
3533
extensions,
3634
fileSystem,
3735
conditionNames,
36+
mainFields,
3837
useSyncFileSystemCalls: true,
3938
...restOptions,
4039
})

0 commit comments

Comments
 (0)
Please sign in to comment.