Skip to content

Commit 9750d6e

Browse files
committed
QoL changes
1 parent 9ec1f60 commit 9750d6e

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

bindings/python/setup.py

+2
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ def build_libraries():
118118
cmake_args = ["cmake", '-B', BUILD_DIR, '-S', UC_DIR, "-DCMAKE_BUILD_TYPE=" + conf]
119119
if os.getenv("TRACE"):
120120
cmake_args += ["-DUNICORN_TRACER=on"]
121+
if conf == "Debug":
122+
cmake_args += ["-DUNICORN_LOGGING=on"]
121123
subprocess.check_call(cmake_args, cwd=UC_DIR)
122124
threads = os.getenv("THREADS", "4")
123125
subprocess.check_call(["cmake", "--build", ".", "-j" + threads], cwd=BUILD_DIR)

tests/regress/jumping.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
# rdx would never be set to 0xbabe unless we set zf to 1
1313
CODE = (
1414
b"\x48\x31\xc0" # xor rax, rax
15-
b"\x48\xb8\x04\x00\x00\x00\x00\x00\x00\x00" # movabs rax, 0x4
16-
b"\x48\x3d\x05\x00\x00\x00" # cmp rax, 0x5 <-- never true, zf is cleared
17-
b"\x74\x05" # je 0x1a
15+
b"\x48\xb8\x04\x00\x00\x00\x00\x00\x00\x00" # 03: movabs rax, 0x4
16+
b"\x48\x3d\x05\x00\x00\x00" # 0d: cmp rax, 0x5 <-- never true, zf is cleared
17+
b"\x74\x05" # 13: je 0x1a
1818
b"\xe9\x0f\x00\x00\x00" # jmp 0x29
1919
b"\x48\xba\xbe\xba\x00\x00\x00\x00\x00\x00" # 1a: movabs rdx, 0xbabe <-- never reached unless we set zf
2020
b"\xe9\x0f\x00\x00\x00" # jmp 0x38

tests/regress/regress.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def __setup_logger(name):
2929

3030

3131
logger = __setup_logger('UnicornRegress')
32-
logger.setLevel(logging.INFO)
32+
logger.setLevel(os.environ.get("UNICORN_DEBUG", "INFO").upper())
3333

3434

3535
def main():

0 commit comments

Comments
 (0)