Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings/zig: Fix sample_riscv_zig partial writes and logging #2133

Merged
merged 1 commit into from
Mar 16, 2025
Merged

bindings/zig: Fix sample_riscv_zig partial writes and logging #2133

merged 1 commit into from
Mar 16, 2025

Conversation

fervagar
Copy link

  • Use full code length (instead of subtracting 1) when writing instructions.
  • Uniformly zero-pad addresses in logs and print hexadecimal.
  • Correct the instruction-hook callback in test_riscv2.

@fervagar
bindings/zig: Fix sample_riscv_zig partial writes and logging
31f30d4 
- Use full code length (instead of subtracting 1) when writing instructions.
- Uniformly zero-pad addresses in logs and print hexadecimal.
- Correct the instruction-hook callback in test_riscv2.
@wtdcode
Copy link
Member

wtdcode commented Mar 16, 2025

Thanks!

@wtdcode wtdcode merged commit d755a8b into unicorn-engine:dev Mar 16, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fervagar @wtdcode