Skip to content

Commit 0b86c9b

Browse files
fix: use system certs for tls (#7357)
### Description Enable the feature for using native certs and not just the ones shipped with `turbo`. See [this readme](https://github.com/rustls/rustls-native-certs?tab=readme-ov-file#should-i-use-this-or-webpki-roots) for a comparison between these features. If you compare the Go implementations ([linux](https://go.dev/src/crypto/x509/root_linux.go), [macos](https://go.dev/src/crypto/x509/root_darwin.go), [windows](https://go.dev/src/crypto/x509/root_windows.go)), this gets us closer to that behavior. Both `weppki-roots` and `rustls-native-certs` can be used at the same time and [both sources](https://docs.rs/reqwest/latest/src/reqwest/async_impl/client.rs.html#465) will be added to the [client when built](https://docs.rs/reqwest/latest/src/reqwest/async_impl/client.rs.html#482) I believe this should address #7317 and some reports in #6765 ### Testing Instructions Verified that new build still works with Vercel Remote Cache. Given that this feature is additive, I don't expect us to lose any functionality. Closes TURBO-2333
1 parent f1ccc76 commit 0b86c9b

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

Cargo.lock

+13
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/turborepo-api-client/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ license = "MPL-2.0"
77
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
88
[features]
99
native-tls = ["reqwest/native-tls"]
10-
rustls-tls = ["reqwest/rustls-tls"]
10+
rustls-tls = ["reqwest/rustls-tls-native-roots"]
1111

1212
[dev-dependencies]
1313
http = "0.2.9"

0 commit comments

Comments
 (0)