Skip to content

Commit 0be73a8

Browse files
committed
Fix compile errors
1 parent c691908 commit 0be73a8

File tree

7 files changed

+19
-11
lines changed

7 files changed

+19
-11
lines changed

crates/turborepo-lib/src/engine/builder.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -760,7 +760,7 @@ mod test {
760760
$(
761761
let path = $root.join_components(&["packages", $name, "package.json"]);
762762
let dependencies = Some($deps.iter().map(|dep: &&str| (dep.to_string(), "workspace:*".to_string())).collect());
763-
let package_json = PackageJson { name: Some($name.to_string()), dependencies, ..Default::default() };
763+
let package_json = PackageJson { name: Some(Spanned::new($name.to_string())), dependencies, ..Default::default() };
764764
_map.insert(path, package_json);
765765
)+
766766
_map

crates/turborepo-lib/src/engine/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,7 @@ mod test {
638638
};
639639

640640
let package = PackageJson {
641-
name: Some(name.to_string()),
641+
name: Some(Spanned::new(name.to_string())),
642642
scripts,
643643
..Default::default()
644644
};

crates/turborepo-lib/src/run/scope/filter.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -713,6 +713,7 @@ mod test {
713713
use tempfile::TempDir;
714714
use test_case::test_case;
715715
use turbopath::{AbsoluteSystemPathBuf, AnchoredSystemPathBuf, RelativeUnixPathBuf};
716+
use turborepo_errors::Spanned;
716717
use turborepo_repository::{
717718
change_mapper::PackageInclusionReason,
718719
discovery::PackageDiscovery,
@@ -806,7 +807,7 @@ mod test {
806807
RelativeUnixPathBuf::new(format!("{package_path}/package.json")).unwrap(),
807808
),
808809
PackageJson {
809-
name: Some(name.to_string()),
810+
name: Some(Spanned::new(name.to_string())),
810811
dependencies: dependencies.get(name).map(|v| {
811812
v.iter()
812813
.map(|name| (name.to_string(), "*".to_string()))

crates/turborepo-lsp/src/lib.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ impl LanguageServer for Backend {
325325
let package_json_name = if repo_root.contains(&wd.package_json) {
326326
Some("//")
327327
} else {
328-
package_json.name.as_deref()
328+
package_json.name.as_ref().map(|name| name.as_str())
329329
};
330330

331331
// todo: use jsonc_ast instead of text search
@@ -613,7 +613,7 @@ impl LanguageServer for Backend {
613613
.iter()
614614
.flat_map(|p| p.scripts.keys().map(move |k| (p.name.clone(), k)))
615615
.map(|(package, s)| CompletionItem {
616-
label: format!("{}#{}", package.unwrap_or_default(), s),
616+
label: format!("{}#{}", package.unwrap_or_default().into_inner(), s),
617617
kind: Some(CompletionItemKind::FIELD),
618618
..Default::default()
619619
});
@@ -708,7 +708,7 @@ impl Backend {
708708
{
709709
Some("//".to_string())
710710
} else {
711-
package_json.name
711+
package_json.name.map(|name| name.into_inner())
712712
};
713713
Some(
714714
package_json

crates/turborepo-repository/src/package_graph/builder.rs

+5-3
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,8 @@ impl PackageInfo {
591591
mod test {
592592
use std::assert_matches::assert_matches;
593593

594+
use turborepo_errors::Spanned;
595+
594596
use super::*;
595597

596598
struct MockDiscovery;
@@ -618,7 +620,7 @@ mod test {
618620
let builder = PackageGraphBuilder::new(
619621
&root,
620622
PackageJson {
621-
name: Some("root".into()),
623+
name: Some(Spanned::new("root".into())),
622624
..Default::default()
623625
},
624626
)
@@ -628,14 +630,14 @@ mod test {
628630
map.insert(
629631
root.join_component("a"),
630632
PackageJson {
631-
name: Some("foo".into()),
633+
name: Some(Spanned::new("foo".into())),
632634
..Default::default()
633635
},
634636
);
635637
map.insert(
636638
root.join_component("b"),
637639
PackageJson {
638-
name: Some("foo".into()),
640+
name: Some(Spanned::new("foo".into())),
639641
..Default::default()
640642
},
641643
);

crates/turborepo-repository/src/package_graph/mod.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,7 @@ mod test {
623623
use std::assert_matches::assert_matches;
624624

625625
use serde_json::json;
626+
use turborepo_errors::Spanned;
626627

627628
use super::*;
628629
use crate::discovery::PackageDiscovery;
@@ -652,7 +653,7 @@ mod test {
652653
let pkg_graph = PackageGraph::builder(
653654
&root,
654655
PackageJson {
655-
name: Some("my-package".to_owned()),
656+
name: Some(Spanned::new("my-package".to_owned())),
656657
..Default::default()
657658
},
658659
)

packages/turbo-repository/rust/src/internal.rs

+5-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,11 @@ impl Workspace {
132132
// package_json_path)
133133
path.parent()
134134
.map(|package_path| {
135-
Ok(Package::new(name, &self.workspace_state.root, package_path))
135+
Ok(Package::new(
136+
name.into_inner(),
137+
&self.workspace_state.root,
138+
package_path,
139+
))
136140
})
137141
.or_else(|| Some(Err(Error::MissingParent(path.to_owned()))))
138142
})

0 commit comments

Comments
 (0)