Skip to content

Commit 2a2f7cf

Browse files
authored
ci: add check-types task to examples testing (#9824)
### Description In the interest of keeping the examples robust, let's also run the newly added `check-types` task in CI to ensure those stay in the green when people try them out for the first time, too. Doing this uncovered some issues with existing examples, so glad to see that this will get us to a more stable place! A notable exception, unfortunately, is going to be the `check-types` in `with-svelte`. Svelte appears to be doing some type generation that can interrupt the type-checking process and make it flake out. ### Testing Instructions CI
1 parent e0f910a commit 2a2f7cf

File tree

7 files changed

+62
-173
lines changed

7 files changed

+62
-173
lines changed

.github/dependabot.yml

+2
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ updates:
4949
- dependency-name: "react-dom"
5050
- dependency-name: "@types/react"
5151
- dependency-name: "@types/react-dom"
52+
# We can't upgrade versions of this due to npm
53+
- dependency-name: "vite"
5254

5355
- package-ecosystem: "npm"
5456
directory: "/examples/non-monorepo"

examples/kitchen-sink/apps/admin/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111
},
1212
"dependencies": {
1313
"@repo/ui": "workspace:*",
14-
"react": "^19.0.0",
15-
"react-dom": "^19.0.0"
14+
"react": "^18.3.1",
15+
"react-dom": "^18.3.1"
1616
},
1717
"devDependencies": {
1818
"@repo/eslint-config": "workspace:*",
1919
"@repo/typescript-config": "workspace:*",
20-
"@types/react": "^19.0.8",
21-
"@types/react-dom": "^19.0.3",
20+
"@types/react": "^18.3.18",
21+
"@types/react-dom": "^18.3.5",
2222
"@vitejs/plugin-react": "^4.3.4",
2323
"typescript": "5.7.3",
24-
"vite": "^6.0.11"
24+
"vite": "^5.4.14"
2525
}
2626
}

examples/kitchen-sink/apps/blog/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818
"@vercel/analytics": "^1.4.1",
1919
"@vercel/remix": "2.15.2",
2020
"isbot": "^5.1.21",
21-
"react": "^18.2.0",
22-
"react-dom": "^18.2.0"
21+
"react": "^18.3.1",
22+
"react-dom": "^18.3.1"
2323
},
2424
"devDependencies": {
2525
"@remix-run/dev": "^2.15.2",
26-
"@types/react": "^18.2.20",
27-
"@types/react-dom": "^18.2.7",
26+
"@types/react": "^18.3.18",
27+
"@types/react-dom": "^18.3.5",
2828
"@typescript-eslint/eslint-plugin": "^8.22.0",
2929
"@typescript-eslint/parser": "^8.22.0",
3030
"@vercel/remix": "2.15.2",

examples/kitchen-sink/apps/storefront/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@
1414
"@repo/logger": "workspace:*",
1515
"@repo/ui": "workspace:*",
1616
"next": "^15.1.6",
17-
"react": "^19.0.0",
18-
"react-dom": "^19.0.0"
17+
"react": "^18.3.1",
18+
"react-dom": "^18.3.1"
1919
},
2020
"devDependencies": {
2121
"@next/eslint-plugin-next": "^15.1.6",
2222
"@repo/eslint-config": "workspace:*",
2323
"@repo/typescript-config": "workspace:*",
2424
"@types/node": "^22.10.10",
25-
"@types/react": "^19.0.8",
26-
"@types/react-dom": "^19.0.3",
25+
"@types/react": "^18.3.18",
26+
"@types/react-dom": "^18.3.5",
2727
"typescript": "5.7.3"
2828
}
2929
}

examples/kitchen-sink/packages/ui/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@
3535
"@repo/jest-presets": "workspace:*",
3636
"@repo/typescript-config": "workspace:*",
3737
"@types/node": "^22.10.10",
38-
"@types/react": "^19.0.8",
39-
"@types/react-dom": "^19.0.3",
38+
"@types/react": "^18.3.18",
39+
"@types/react-dom": "^18.3.5",
4040
"jest": "^29.7.0",
41-
"react": "^19.0.0",
42-
"react-dom": "^19.0.0",
41+
"react": "^18.3.1",
42+
"react-dom": "^18.3.1",
4343
"tsup": "^8.3.6",
4444
"typescript": "5.7.3"
4545
}

0 commit comments

Comments
 (0)