Skip to content

Commit 348756f

Browse files
fix: filter logic (#9653)
### Description const availableBinaries = [ 'turbo-darwin-64/bin/turbo', 'turbo-darwin-arm64/bin/turbo', 'turbo-linux-64/bin/turbo', 'turbo-linux-arm64/bin/turbo', 'turbo-windows-64/bin/turbo.exe', 'turbo-windows-arm64/bin/turbo.exe' ]; const correctBinary = 'turbo-darwin-arm64/bin/turbo'; const definitelyWrongBinaries = availableBinaries.filter(binary => binary !== correctBinary || binary !== correctBinary); filter function internal condition or after meaningless, The result of definitelyWrongBinaries const availableBinaries = [ 'turbo-darwin-64/bin/turbo', 'turbo-linux-64/bin/turbo', 'turbo-linux-arm64/bin/turbo', 'turbo-windows-64/bin/turbo.exe', 'turbo-windows-arm64/bin/turbo.exe' ]; In fact 'turbo-darwin-64/bin/turbo' should also go ### Testing Instructions const correctBinary = 'turbo-darwin-arm64/bin/turbo'; const alternateBinary = 'turbo-darwin-64/bin/turbo' const definitelyWrongBinaries = availableBinaries.filter(binary => binary !== correctBinary && binary !== alternateBinary); definitelyWrongBinaries result for others Co-authored-by: Chris Olszewski <[email protected]>
1 parent 51c8361 commit 348756f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/turbo/bin/turbo

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ function getBinaryPath() {
170170

171171
// Has the wrong platform's binaries available.
172172
const availableBinaries = availablePlatforms.map(platform => availableArchs.map(arch => `turbo-${platform}-${arch}/bin/turbo${platform === 'windows' ? '.exe' : ''}`)).flat();
173-
const definitelyWrongBinaries = availableBinaries.filter(binary => binary !== correctBinary || binary !== correctBinary);;
173+
const definitelyWrongBinaries = availableBinaries.filter(binary => binary !== correctBinary && binary !== alternateBinary);
174174
const otherInstalled = definitelyWrongBinaries.filter(binaryPath => {
175175
try {
176176
return require.resolve(binaryPath);

0 commit comments

Comments
 (0)