Skip to content

Commit 4370322

Browse files
chore(ci): install optional deps when testing JS packages (#10170)
### Description See failure on #10168 ``` Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory. ``` [source](https://github.com/vercel/turborepo/actions/runs/13862424976/job/38794202787#step:6:461) Rollup distributes binaries using the same strategy we do so skipping installing optional dependencies skips installing the actual binary. ### Testing Instructions Will open PR against this one that triggers `eslint-config-turbo#build`: https://github.com/vercel/turborepo/actions/runs/13862902922?pr=10171
1 parent 8725fee commit 4370322

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

.github/workflows/test-js-packages.yml

-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ jobs:
5858
- name: "Setup Node"
5959
uses: ./.github/actions/setup-node
6060
with:
61-
extra-flags: --no-optional
6261
node-version: ${{ matrix.node-version }}
6362
env:
6463
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1

0 commit comments

Comments
 (0)