Move serialization to ser.rs and add tests

Author: camero2734

crates/turborepo-lockfiles/src/bun/mod.rs

@@ -4,14 +4,15 @@ use biome_json_formatter::context::JsonFormatOptions;
 use biome_json_parser::JsonParserOptions;
 use id::PossibleKeyIter;
 use itertools::Itertools as _;
-use serde::{ser::SerializeTuple, Deserialize, Serialize};
+use serde::{Deserialize, Serialize};
 use serde_json::Value;
 use turborepo_errors::ParseDiagnostic;
 
 use crate::Lockfile;
 
 mod de;
 mod id;
+mod ser;
 
 type Map<K, V> = std::collections::BTreeMap<K, V>;
 
@@ -99,25 +100,6 @@ struct RootInfo {
     bin_dir: Option<String>,
 }
 
-impl Serialize for PackageEntry {
-    fn serialize<S: serde::Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
-        let mut tuple = serializer.serialize_tuple(4)?;
-        tuple.serialize_element(&self.ident)?;
-
-        let Some(info) = &self.info else {
-            return tuple.end();
-        };
-
-        tuple.serialize_element(&self.registry.as_deref().unwrap_or(""))?;
-        tuple.serialize_element(info)?;
-        tuple.serialize_element(&self.checksum)?;
-        if let Some(root) = &self.root {
-            tuple.serialize_element(root)?;
-        }
-        tuple.end()
-    }
-}
-
 impl Lockfile for BunLockfile {
     #[tracing::instrument(skip(self, workspace_path))]
     fn resolve_package(
@@ -252,13 +234,16 @@ impl BunLockfile {
         let mut new_patched_dependencies = Map::new();
 
         for package in packages {
-            let package_key = self.key_to_entry.get(package).expect("package key");
+            let package_key = self
+                .key_to_entry
+                .get(package)
+                .expect("package key should exist");
             if let Some((key, entry)) = self.package_entry(&package_key) {
                 new_packages.insert(key.to_string(), entry.clone());
             }
         }
 
-        // Add root workspace
+        // The root workspace is "" in the lockfile
         let root_workspace = self
             .data
             .workspaces
@@ -364,6 +349,7 @@ impl PackageInfo {
 #[cfg(test)]
 mod test {
     use pretty_assertions::assert_eq;
+    use serde_json::json;
     use test_case::test_case;
 
     use super::*;

crates/turborepo-lockfiles/src/bun/ser.rs

@@ -0,0 +1,82 @@
+use serde::{ser::SerializeTuple, Serialize};
+
+use super::PackageEntry;
+
+impl Serialize for PackageEntry {
+    fn serialize<S: serde::Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
+        let mut tuple = serializer.serialize_tuple(4)?;
+        tuple.serialize_element(&self.ident)?;
+
+        if let Some(info) = &self.info {
+            tuple.serialize_element(&self.registry.as_deref().unwrap_or(""))?;
+            tuple.serialize_element(info)?;
+            tuple.serialize_element(&self.checksum)?;
+            if let Some(root) = &self.root {
+                tuple.serialize_element(root)?;
+            }
+        };
+
+        tuple.end()
+    }
+}
+
+#[cfg(test)]
+mod test {
+    use serde_json::json;
+
+    use super::*;
+    use crate::bun::PackageInfo;
+
+    #[test]
+    fn test_serialize_registry_package() {
+        let package = PackageEntry {
+            ident: "[email protected]".into(),
+            registry: Some("registry".into()),
+            info: Some(PackageInfo {
+                dependencies: [("is-number".into(), "^6.0.0".into())]
+                    .into_iter()
+                    .collect(),
+                ..Default::default()
+            }),
+            checksum: Some("sha".into()),
+            root: None,
+        };
+
+        let expected =
+            json!(["[email protected]", "registry", {"dependencies": {"is-number": "^6.0.0"}}, "sha"]);
+        let actual = serde_json::to_value(&package).unwrap();
+        assert_eq!(actual, expected);
+    }
+
+    #[test]
+    fn test_serialize_registry_package_no_deps() {
+        let package = PackageEntry {
+            ident: "[email protected]".into(),
+            registry: Some("registry".into()),
+            info: Some(PackageInfo {
+                ..Default::default()
+            }),
+            checksum: Some("sha".into()),
+            root: None,
+        };
+
+        let expected = json!(["[email protected]", "registry", {}, "sha"]);
+        let actual = serde_json::to_value(&package).unwrap();
+        assert_eq!(actual, expected);
+    }
+
+    #[test]
+    fn test_serialize_workspace_package() {
+        let package = PackageEntry {
+            ident: "@workspace/package".into(),
+            registry: None,
+            info: None,
+            checksum: None,
+            root: None,
+        };
+
+        let expected = json!(["@workspace/package"]);
+        let actual = serde_json::to_value(&package).unwrap();
+        assert_eq!(actual, expected);
+    }
+}