Skip to content

Commit 5c11459

Browse files
authored
chore:(logging): improve debug logs with -vv (#8867)
1 parent 34c9a58 commit 5c11459

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

crates/turborepo-lib/src/engine/execute.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,9 @@ impl Engine {
116116

117117
if let Err(StopExecution) = result.await.unwrap_or_else(|_| {
118118
// If the visitor doesn't send a callback, then we assume the task finished
119-
debug!("Engine visitor dropped callback sender without sending result");
119+
tracing::trace!(
120+
"Engine visitor dropped callback sender without sending result"
121+
);
120122
Ok(())
121123
}) {
122124
if walker

crates/turborepo-lib/src/task_hash.rs

+8-6
Original file line numberDiff line numberDiff line change
@@ -366,12 +366,14 @@ impl<'a> TaskHasher<'a> {
366366
let external_deps_hash =
367367
is_monorepo.then(|| get_external_deps_hash(&workspace.transitive_dependencies));
368368

369-
debug!(
370-
"task hash env vars for {}:{}\n vars: {:?}",
371-
task_id.package(),
372-
task_id.task(),
373-
hashable_env_pairs
374-
);
369+
if !hashable_env_pairs.is_empty() {
370+
debug!(
371+
"task hash env vars for {}:{}\n vars: {:?}",
372+
task_id.package(),
373+
task_id.task(),
374+
hashable_env_pairs
375+
);
376+
}
375377

376378
let package_dir = workspace.package_path().to_unix();
377379
let is_root_package = package_dir.is_empty();

crates/turborepo-telemetry/src/lib.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ use tokio::{
2121
sync::{mpsc, oneshot},
2222
task::{JoinError, JoinHandle},
2323
};
24-
use tracing::{debug, error};
24+
use tracing::{debug, error, trace};
2525
use turborepo_api_client::telemetry;
2626
use turborepo_ui::{color, BOLD, GREY, UI};
2727
use uuid::Uuid;
@@ -203,15 +203,15 @@ impl<C: telemetry::TelemetryClient + Clone + Send + Sync + 'static> Worker<C> {
203203
pub fn flush_events(&mut self) {
204204
if !self.buffer.is_empty() {
205205
let events = std::mem::take(&mut self.buffer);
206-
debug!(
207-
"Starting telemetry event queue flush (num_events={:?})",
208-
events.len()
209-
);
206+
let num_events = events.len();
210207
let handle = self.send_events(events);
211208
if let Some(handle) = handle {
212209
self.senders.push(handle);
213210
}
214-
debug!("Done telemetry event queue flush");
211+
trace!(
212+
"Flushed telemetry event queue (num_events={:?})",
213+
num_events
214+
);
215215
}
216216
}
217217

0 commit comments

Comments
 (0)