Skip to content

Commit 8e8c6b7

Browse files
Asupkayanthonyshew
andauthored
chore: standardize type check job name to check-types (#9973)
### Description This pull request standardizes the type checking task name to `check-types` across all example repos. This is good so that new users can learn one way and feel confident they will be able to run this across all repos that need it. ### Testing Instructions Running `turbo check-types` in `with-shell-commands` example ![Screenshot 2025-02-14 at 12 34 21 PM](https://github.com/user-attachments/assets/5252ab8d-8d30-423a-abd5-39e5451ead24) Running `pnpm check-types` in `with-typeorm` repo ![Screenshot 2025-02-14 at 12 34 33 PM](https://github.com/user-attachments/assets/b3ea332f-915d-472f-a36b-e7f5d7f76207) Running `pnpm check-types` in `with-gatsby/apps/web` ![Screenshot 2025-02-14 at 12 43 06 PM](https://github.com/user-attachments/assets/c09a36f9-a6df-4e2f-adea-bc062ff2a181) Running `pnpm check-types` and `pnpm build` in `with-vue-next/apps/web` ![Screenshot 2025-02-14 at 12 44 23 PM](https://github.com/user-attachments/assets/953348d2-8e8b-4759-be3a-cdcc4d469bbd) --------- Co-authored-by: Anthony Shew <[email protected]>
1 parent fee71c1 commit 8e8c6b7

File tree

11 files changed

+12
-12
lines changed

11 files changed

+12
-12
lines changed

examples/with-gatsby/apps/web/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"dev": "gatsby develop",
77
"build": "gatsby build",
88
"start": "gatsby develop",
9-
"typecheck": "tsc --noEmit",
9+
"check-types": "tsc --noEmit",
1010
"lint": "eslint src/ --max-warnings 0"
1111
},
1212
"dependencies": {

examples/with-shell-commands/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ This Turborepo includes the following packages:
3636

3737
If you haven't yet, [install global `turbo`](https://turbo.build/repo/docs/installing#install-globally) to run tasks.
3838

39-
- `turbo build lint type-check`: Runs all tasks in the default graph.
39+
- `turbo build lint check-types`: Runs all tasks in the default graph.
4040
- `turbo build`: A basic command to build `app-a` and `app-b` in parallel.
4141
- `turbo build --filter=app-a`: Building only `app-a` and its dependencies.
4242
- `turbo lint`: A basic command for running lints in all packages in parallel.

examples/with-shell-commands/apps/app-a/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"scripts": {
55
"build": "mkdir -p dist && echo \"Your application output!\" > dist/app-output.txt && echo \"Application A is built!\"",
66
"lint": "echo \"Linted!\"",
7-
"type-check": "echo \"Types checked!\""
7+
"check-types": "echo \"Types checked!\""
88
},
99
"dependencies": {
1010
"pkg-a": "workspace:*",

examples/with-shell-commands/apps/app-b/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"scripts": {
55
"build": "mkdir -p dist && echo \"Your application output!\" > dist/app-output.txt && echo \"Application B is built!\"",
66
"lint": "echo \"Linted!\"",
7-
"type-check": "echo \"Types checked!\""
7+
"check-types": "echo \"Types checked!\""
88
},
99
"dependencies": {
1010
"tooling-config": "workspace:*"

examples/with-shell-commands/packages/pkg-a/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"scripts": {
44
"build": "echo \"Building at the speed of Turbo.\" > output-file.txt && cat output-file.txt",
55
"lint": "echo \"Linted!\"",
6-
"type-check": "echo \"Types checked!\""
6+
"check-types": "echo \"Types checked!\""
77
},
88
"dependencies": {
99
"tooling-config": "workspace:*"

examples/with-shell-commands/packages/pkg-b/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"scripts": {
44
"prebuild": "echo \"Executing pre-build step...\"",
55
"build": "echo \"Welcome to the Turboverse.\" > output-file.txt && cat output-file.txt",
6-
"type-check": "echo \"Types checked!\""
6+
"check-types": "echo \"Types checked!\""
77
},
88
"dependencies": {
99
"tooling-config": "workspace:*"

examples/with-shell-commands/turbo.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
},
1414
"prebuild": {},
1515
"lint": {},
16-
"type-check": {}
16+
"check-types": {}
1717
}
1818
}

examples/with-typeorm/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"build": "turbo run build",
55
"dev": "turbo run dev",
66
"lint": "turbo run lint",
7-
"type-check": "turbo run type-check",
7+
"check-types": "turbo run check-types",
88
"format": "prettier --write \"**/*.{ts,tsx,md}\""
99
},
1010
"devDependencies": {

examples/with-typeorm/packages/typeorm-service/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"lint": "eslint src/ --max-warnings 0",
1010
"test:watch": "vitest",
1111
"test": "vitest run",
12-
"type-check": "tsc --noEmit"
12+
"check-types": "tsc --noEmit"
1313
},
1414
"peerDependencies": {
1515
"typeorm": "^0.3.20"

examples/with-typeorm/turbo.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"lint": {
1010
"dependsOn": ["^lint"]
1111
},
12-
"type-check": {},
12+
"check-types": {},
1313
"test": {
1414
"cache": false,
1515
"inputs": ["**/*.test.ts", "**/*.test.tsx", "vitest.config.ts"]

examples/with-vue-nuxt/apps/web/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
"private": true,
55
"scripts": {
66
"dev": "vite --port 3000",
7-
"build": "run-p type-check \"build-only {@}\" --",
7+
"build": "run-p check-types \"build-only {@}\" --",
88
"preview": "vite preview",
99
"build-only": "vite build",
10-
"type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
10+
"check-types": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
1111
"lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore"
1212
},
1313
"dependencies": {

0 commit comments

Comments
 (0)