pass through target

Author: dimitropoulos

.github/workflows/turborepo-library-release.yml

@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
     inputs:
       dry_run:
-        description: "Do a dry run, skipping the final publish step."
+        description: Do a dry run, skipping the final publish step.
         type: boolean
 
 jobs:
@@ -18,12 +18,13 @@ jobs:
       matrix:
         settings:
           - host: macos-latest
-            target: "aarch64-apple-darwin"
+            target: aarch64-apple-darwin
+
           - host: macos-latest
-            target: "x86_64-apple-darwin"
+            target: x86_64-apple-darwin
 
           - host: ubuntu-latest
-            target: "aarch64-unknown-linux-gnu"
+            target: aarch64-unknown-linux-gnu
             setup: |
               sudo apt update
               sudo apt install -y g++-aarch64-linux-gnu libc6-dev-arm64-cross
@@ -32,7 +33,7 @@ jobs:
               echo "CXX_aarch64_unknown_linux_gnu=aarch64-linux-gnu-g++" >> $GITHUB_ENV
 
           - host: ubuntu-latest
-            target: "x86_64-unknown-linux-gnu"
+            target: x86_64-unknown-linux-gnu
             container: amazon/aws-lambda-nodejs:20
             install: |
               microdnf install -y gcc gcc-c++ git
@@ -42,7 +43,7 @@ jobs:
               pnpm install
 
           - host: ubuntu-latest
-            target: "x86_64-unknown-linux-musl"
+            target: x86_64-unknown-linux-musl
             container: ghcr.io/napi-rs/napi-rs/nodejs-rust:stable-2023-09-17-alpine
             install: |
               apk update && apk upgrade
@@ -56,7 +57,7 @@ jobs:
               pnpm install
 
           - host: ubuntu-latest
-            target: "aarch64-unknown-linux-musl"
+            target: aarch64-unknown-linux-musl
             container: ghcr.io/napi-rs/napi-rs/nodejs-rust:stable-2023-09-17-alpine
             install: |
               apk update && apk upgrade
@@ -73,10 +74,10 @@ jobs:
             rust_env: CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_LINKER=/aarch64-linux-musl-cross/bin/aarch64-linux-musl-gcc RUSTFLAGS="-Ctarget-feature=-crt-static"
 
           - host: windows-latest
-            target: "aarch64-pc-windows-msvc"
+            target: aarch64-pc-windows-msvc
 
           - host: windows-latest
-            target: "x86_64-pc-windows-msvc"
+            target: x86_64-pc-windows-msvc
 
     runs-on: ${{ matrix.settings.host }}
     container:
@@ -123,7 +124,7 @@ jobs:
           path: packages/turbo-repository/native
 
   package:
-    name: "Publish to NPM"
+    name: Publish to NPM
     runs-on: ubuntu-latest
     needs: [build]
     steps:

packages/turbo-repository/package.json

@@ -5,8 +5,8 @@
   "bugs": "https://github.com/vercel/turborepo/issues",
   "homepage": "https://turbo.build/repo",
   "scripts": {
-    "build": "bash scripts/build.sh",
-    "build:release": "bash scripts/build.sh release",
+    "build": "bash scripts/build.sh --dts ../js/index.d.ts",
+    "build:release": "bash scripts/build.sh --release",
     "package": "node scripts/publish.mjs",
     "test": "node --import tsx --test __tests__/*.test.ts"
   },

packages/turbo-repository/scripts/build.sh

@@ -1,6 +1,7 @@
 #!/bin/bash
 
-flags="\
+user_provided_flags="$@"
+script_provided_flags="\
   --platform \
   -p turborepo-napi \
   --cargo-cwd ../../ \
@@ -9,13 +10,7 @@ flags="\
   --js false \
 "
 
-if [ "$1" == "release" ]; then
-  flags+=" --release"
-else
-  flags+=" --dts ../js/index.d.ts"
-fi
-
-node_modules/.bin/napi build $flags
+node_modules/.bin/napi build "$user_provided_flags" "$script_provided_flags"
 
 # Unfortunately, when napi generates a .d.ts file, it doesn't match our formatting rules (it doesn't have semicolons).
 # Since there's now way to configure this from napi itself, so we need to run prettier on it after generating it.