feat(process): distinguish between signals used to kill children (#10049)

### Description

This is a redo of #10027 with some additional refactoring to reduce the
complexity of this code. These changes should lessens the possibilities
of deadlock or race conditions.

I highly recommend viewing each commit individually.

From original PR:
> This is primarily a code move of the `ProcessManager` out of the
`turborepo-lib` crate. We also now differ between a child shutting down
in response to a `SIGINT` vs us killing the child.

> Future PR will be changing how we treat each of these exit outcomes.

The additional commits in this PR:
- Fixed a race condition between between the 2 `wait`s performed by the
`ChildStateManager` where one was called by the task the sent a shutdown
to the child and the other was the default `wait`. If the latter won,
then it would appear another entity killed the child even when it was
really us.
- Changed the return value of `ShutdownStyle::process` to avoid
returning an impossible state
 - Remove unused `ChildState::Exited` field which was never read
- Removed shared state between the child handle and the child state
manager
 - Simplified child methods

The removal of the shared state is possible since we already have the
exit channel shared between the handles and the manager. Using both a
channel and state was error prone as it lead to the following
possibilities:
- What does it mean if the manager is still listening for commands, but
the state shows the child as exited
- What does it mean if the manager channel is closed, but the state
shows the child is still running
Instead we only use the command channel being open/closed as an
indication of if the child is running. Once the manager sees the child
exit, it will send the exit status via the channel and exit resulting in
the channel being closed.

### Testing Instructions

Existing test suite, ran with `hyperfine 'cargo test' -r 500` to attempt
to flush out any races.

Author: chris-olszewski

Cargo.lock

@@ -62,6 +62,7 @@ turborepo-fs = { path = "crates/turborepo-fs" }
 turborepo-lib = { path = "crates/turborepo-lib", default-features = false }
 turborepo-lockfiles = { path = "crates/turborepo-lockfiles" }
 turborepo-microfrontends = { path = "crates/turborepo-microfrontends" }
+turborepo-process = { path = "crates/turborepo-process" }
 turborepo-repository = { path = "crates/turborepo-repository" }
 turborepo-ui = { path = "crates/turborepo-ui" }
 turborepo-unescape = { path = "crates/turborepo-unescape" }

Cargo.toml

@@ -75,15 +75,13 @@ lazy_static = { workspace = true }
 libc = "0.2.140"
 merge = { workspace = true }
 miette = { workspace = true, features = ["fancy"] }
-nix = "0.26.2"
 notify = { workspace = true }
 num_cpus = { workspace = true }
 owo-colors = { workspace = true }
 oxc_resolver = { workspace = true }
 path-clean = "1.0.1"
 petgraph = { workspace = true }
 pidlock = { path = "../turborepo-pidlock" }
-portable-pty = "0.8.1"
 pprof = { version = "0.12.1", features = [
   "prost-codec",
   "frame-pointer",
@@ -138,6 +136,7 @@ turborepo-fs = { path = "../turborepo-fs" }
 turborepo-graph-utils = { path = "../turborepo-graph-utils" }
 turborepo-lockfiles = { workspace = true }
 turborepo-microfrontends = { workspace = true }
+turborepo-process = { workspace = true }
 turborepo-repository = { path = "../turborepo-repository" }
 turborepo-scm = { workspace = true, features = ["git2"] }
 turborepo-signals = { workspace = true }
@@ -156,9 +155,6 @@ which = { workspace = true }
 uds_windows = "1.0.2"
 async-io = "1.12.0"
 
-[target.'cfg(target_os = "windows")'.dev-dependencies]
-windows-sys = { version = "0.59", features = ["Win32_System_Threading"] }
-
 [build-dependencies]
 capnpc = "0.18.0"
 tonic-build = "0.8.4"

crates/turborepo-lib/Cargo.toml

@@ -28,7 +28,6 @@ mod microfrontends;
 mod opts;
 mod package_changes_watcher;
 mod panic_handler;
-mod process;
 mod query;
 mod rewrite_json;
 mod run;

crates/turborepo-lib/src/lib.rs

@@ -13,6 +13,7 @@ use turborepo_api_client::{APIAuth, APIClient};
 use turborepo_cache::AsyncCache;
 use turborepo_env::EnvironmentVariableMap;
 use turborepo_errors::Spanned;
+use turborepo_process::ProcessManager;
 use turborepo_repository::{
     change_mapper::PackageInclusionReason,
     package_graph::{PackageGraph, PackageName},
@@ -44,7 +45,6 @@ use crate::{
     engine::{Engine, EngineBuilder},
     microfrontends::MicrofrontendsConfigs,
     opts::Opts,
-    process::ProcessManager,
     run::{scope, task_access::TaskAccess, task_id::TaskName, Error, Run, RunCache},
     shim::TurboState,
     turbo_json::{TurboJson, TurboJsonLoader, UIMode},

crates/turborepo-lib/src/run/builder.rs

@@ -30,6 +30,7 @@ use turbopath::{AbsoluteSystemPath, AbsoluteSystemPathBuf};
 use turborepo_api_client::{APIAuth, APIClient};
 use turborepo_ci::Vendor;
 use turborepo_env::EnvironmentVariableMap;
+use turborepo_process::ProcessManager;
 use turborepo_repository::package_graph::{PackageGraph, PackageName, PackageNode};
 use turborepo_scm::SCM;
 use turborepo_signals::{listeners::get_signal, SignalHandler};
@@ -45,7 +46,6 @@ use crate::{
     engine::Engine,
     microfrontends::MicrofrontendsConfigs,
     opts::Opts,
-    process::ProcessManager,
     run::{global_hash::get_global_hash_inputs, summary::RunTracker, task_access::TaskAccess},
     task_graph::Visitor,
     task_hash::{get_external_deps_hash, get_internal_deps_hash, PackageInputsHashes},

crates/turborepo-lib/src/run/mod.rs

@@ -4,12 +4,12 @@ use tracing::debug;
 use turbopath::AbsoluteSystemPath;
 use turborepo_env::EnvironmentVariableMap;
 use turborepo_microfrontends::MICROFRONTENDS_PACKAGE;
+use turborepo_process::Command;
 use turborepo_repository::package_graph::{PackageGraph, PackageInfo, PackageName};
 
 use super::Error;
 use crate::{
-    engine::Engine, microfrontends::MicrofrontendsConfigs, opts::TaskArgs, process::Command,
-    run::task_id::TaskId,
+    engine::Engine, microfrontends::MicrofrontendsConfigs, opts::TaskArgs, run::task_id::TaskId,
 };
 
 pub trait CommandProvider {

crates/turborepo-lib/src/task_graph/visitor/command.rs

@@ -8,6 +8,7 @@ use console::StyledObject;
 use tokio::sync::oneshot;
 use tracing::{error, Instrument};
 use turborepo_env::{platform::PlatformEnv, EnvironmentVariableMap};
+use turborepo_process::{ChildExit, Command, ProcessManager};
 use turborepo_repository::package_manager::PackageManager;
 use turborepo_telemetry::events::{task::PackageTaskEventBuilder, TrackedErrors};
 use turborepo_ui::{ColorConfig, OutputWriter};
@@ -22,7 +23,6 @@ use crate::{
     cli::ContinueMode,
     config::UIMode,
     engine::{Engine, StopExecution},
-    process::{ChildExit, Command, ProcessManager},
     run::{summary::TaskTracker, task_access::TaskAccess, task_id::TaskId, CacheOutput, TaskCache},
     task_hash::TaskHashTracker,
 };
@@ -454,7 +454,7 @@ impl ExecContext {
             // Something else killed the child
             ChildExit::KilledExternal => Err(InternalError::ExternalKill),
             // The child was killed by turbo indicating a shutdown
-            ChildExit::Killed => Ok(ExecOutcome::Shutdown),
+            ChildExit::Killed | ChildExit::Interrupted => Ok(ExecOutcome::Shutdown),
         }
     }
 }

crates/turborepo-lib/src/task_graph/visitor/exec.rs

@@ -24,6 +24,7 @@ use turbopath::{AbsoluteSystemPath, AnchoredSystemPath};
 use turborepo_ci::{Vendor, VendorBehavior};
 use turborepo_env::{platform::PlatformEnv, EnvironmentVariableMap};
 use turborepo_errors::TURBO_SITE;
+use turborepo_process::ProcessManager;
 use turborepo_repository::package_graph::{PackageGraph, PackageName, ROOT_PKG_NAME};
 use turborepo_telemetry::events::{
     generic::GenericEventBuilder, task::PackageTaskEventBuilder, EventBuilder, TrackedErrors,
@@ -37,7 +38,6 @@ use crate::{
     engine::{Engine, ExecutionOptions},
     microfrontends::MicrofrontendsConfigs,
     opts::RunOpts,
-    process::ProcessManager,
     run::{
         global_hash::GlobalHashableInputs,
         summary::{self, GlobalHashSummary, RunTracker},

crates/turborepo-lib/src/task_graph/visitor/mod.rs

@@ -0,0 +1,27 @@
+[package]
+name = "turborepo-process"
+version = "0.1.0"
+edition = "2021"
+license = "MIT"
+
+[dev-dependencies]
+test-case = { workspace = true }
+tracing-test = { version = "0.2.4", features = ["no-env-filter"] }
+
+[dependencies]
+atty = { workspace = true }
+console = { workspace = true }
+futures = { workspace = true }
+itertools = { workspace = true }
+libc = "0.2.140"
+nix = "0.26.2"
+portable-pty = "0.8.1"
+tokio = { workspace = true, features = ["full", "time"] }
+tracing.workspace = true
+turbopath = { workspace = true }
+
+[lints]
+workspace = true
+
+[target.'cfg(target_os = "windows")'.dev-dependencies]
+windows-sys = { version = "0.59", features = ["Win32_System_Threading"] }