Skip to content

Commit 2f83928

Browse files
author
Miguel Martínez Triviño
authored
fix: update brittle test case (#133)
Signed-off-by: Miguel Martinez Trivino <[email protected]>
1 parent a6fbf08 commit 2f83928

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

pkg/mover/chart_test.go

+13-3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
"os"
1010
"path/filepath"
1111
"reflect"
12+
"sort"
1213
"testing"
1314

1415
"helm.sh/helm/v3/pkg/chart"
@@ -714,12 +715,21 @@ func TestGroupChangesByChart(t *testing.T) {
714715
want := make(map[*chart.Chart][]*internal.RewriteAction)
715716
// parent chart
716717
want[rootChart] = []*internal.RewriteAction{r1}
718+
719+
firstLevelDeps := rootChart.Dependencies()
720+
// Sort dependencies since they come in arbitrary order
721+
sort.Slice(firstLevelDeps, func(i, j int) bool {
722+
return firstLevelDeps[i].Name() < firstLevelDeps[j].Name()
723+
})
724+
717725
// Subchart1
718-
want[rootChart.Dependencies()[0]] = []*internal.RewriteAction{subchart1R1, subchart1R2}
726+
want[firstLevelDeps[0]] = []*internal.RewriteAction{subchart1R1, subchart1R2}
727+
719728
// Subchart2
720-
want[rootChart.Dependencies()[1]] = []*internal.RewriteAction{subchart2R1}
729+
want[firstLevelDeps[1]] = []*internal.RewriteAction{subchart2R1}
730+
721731
// Subchart1.Subchart3
722-
want[rootChart.Dependencies()[0].Dependencies()[0]] = []*internal.RewriteAction{subchart1Subchart3}
732+
want[firstLevelDeps[0].Dependencies()[0]] = []*internal.RewriteAction{subchart1Subchart3}
723733

724734
// Compare output
725735
if got := groupChangesByChart(rewrites, rootChart); !reflect.DeepEqual(got, want) {

0 commit comments

Comments
 (0)