Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] Fix: support for block volumes in velero helm #648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sinhaashish
Copy link

Special notes for your reviewer:

The velero cli had the support for block volumes .
This support was not present in velero helm, refer here .

This PR add the support in Helm charts for velero

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped, please refer to the chart version instruction
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@sinhaashish
Copy link
Author

@qiuming-best @ywk253100 @jenting PTAL

@jenting
Copy link
Collaborator

jenting commented Mar 4, 2025

@sinhaashish plz help rebase the branch, thx

@sinhaashish sinhaashish force-pushed the backup-block-volume branch from 4e07750 to de91c46 Compare March 4, 2025 17:36
@sinhaashish
Copy link
Author

@sinhaashish plz help rebase the branch, thx

done

@jenting
Copy link
Collaborator

jenting commented Mar 4, 2025

@sinhaashish Please bump the Chart version, thanks.

@sinhaashish sinhaashish force-pushed the backup-block-volume branch from de91c46 to a5cb4c9 Compare March 10, 2025 09:45
@sinhaashish
Copy link
Author

@sinhaashish Please bump the Chart version, thanks.

@jenting Thanks, have bumped up the version.

jenting
jenting previously approved these changes Mar 10, 2025
@jenting
Copy link
Collaborator

jenting commented Mar 10, 2025

@sinhaashish CI failed, could you help?

@sinhaashish
Copy link
Author

@sinhaashish CI failed, could you help?

Hey @jenting
I added type: DirectoryOrCreate in the node-agent-daemonset.yaml, I dont find any reason of ci failure. Can you help me with it. and how to run the ci locally as i dont find any ci run immediately after PR is refreshed with new commit.

@jenting
Copy link
Collaborator

jenting commented Mar 15, 2025

Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(DaemonSet.spec.template.spec.volumes[2].hostPath): missing required field "path" in io.k8s.api.core.v1.HostPathVolumeSource

@sinhaashish
Could you please check is the YAML works good locally? Or check the CI test values.yaml file.

@sinhaashish sinhaashish force-pushed the backup-block-volume branch from ed17a84 to a94eaa5 Compare March 18, 2025 16:40
@sinhaashish
Copy link
Author

Thanks @jenting
I tested this locally and it works now. I have added the default value in node-agent-daemonset.yaml .

@qiuming-best @jenting PTAL

@sinhaashish
Copy link
Author

@ywk253100 PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants