Skip to content

Commit 35d7e2b

Browse files
mjauvinLukeTowersbennothommo
authored
Add support for translation strings in FormField->options() (#1192)
Co-authored-by: Luke Towers <[email protected]> Co-authored-by: Ben Thomson <[email protected]>
1 parent 2cde3b8 commit 35d7e2b

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

modules/backend/classes/FormField.php

+7-6
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
namespace Backend\Classes;
44

55
use BackedEnum;
6-
use Html;
6+
use Illuminate\Support\Facades\Lang;
77
use Winter\Storm\Database\Model;
88
use Winter\Storm\Html\Helper as HtmlHelper;
9+
use Winter\Storm\Support\Facades\Html;
910
use Winter\Storm\Support\Str;
1011

1112
/**
@@ -229,10 +230,11 @@ public function options($value = null)
229230
if ($value === null) {
230231
if (is_array($this->options)) {
231232
return $this->options;
232-
}
233-
elseif (is_callable($this->options)) {
233+
} elseif (is_callable($this->options)) {
234234
$callable = $this->options;
235235
return $callable();
236+
} elseif (is_string($this->options) && is_array($options = Lang::get($this->options))) {
237+
return $options;
236238
}
237239

238240
return [];
@@ -434,9 +436,8 @@ public function getAttributes($position = 'field', $htmlBuild = true)
434436
// Field is required, so add the "required" attribute
435437
if ($position === 'field' && $this->required && (!isset($result['required']) || $result['required'])) {
436438
$result['required'] = '';
437-
}
438-
// The "required" attribute is set and falsy, so unset it
439-
elseif ($position === 'field' && isset($result['required']) && !$result['required']) {
439+
} elseif ($position === 'field' && isset($result['required']) && !$result['required']) {
440+
// The "required" attribute is set and falsy, so unset it
440441
unset($result['required']);
441442
}
442443

0 commit comments

Comments
 (0)