Skip to content

Commit d49266a

Browse files
committed
Make popup textarea HTML5-compliant in Inspector editor.
Previously, this was a self-closing tag with a value attribute. Neither are supported for the textarea tag in HTML5. It appears that browsers now are actually checking this and/or won't work with it. Fixes #5222.
1 parent a56e0cd commit d49266a

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

modules/system/assets/ui/js/inspector.editor.text.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
TextEditor.prototype.constructor = Base
1515

1616
TextEditor.prototype.setLinkText = function(link, value) {
17-
var value = value !== undefined ? value
17+
var value = value !== undefined ? value
1818
: this.inspector.getPropertyValue(this.propertyDefinition.property)
1919

2020
if (value === undefined) {
@@ -24,7 +24,7 @@
2424
if (!value) {
2525
value = this.propertyDefinition.placeholder
2626
$.oc.foundation.element.addClass(link, 'placeholder')
27-
}
27+
}
2828
else {
2929
$.oc.foundation.element.removeClass(link, 'placeholder')
3030
}
@@ -47,7 +47,8 @@
4747
<div class="modal-body"> \
4848
<div class="form-group"> \
4949
<p class="inspector-field-comment"></p> \
50-
<textarea class="form-control size-small field-textarea" name="name" value=""/> \
50+
<textarea class="form-control size-small field-textarea" name="name"> \
51+
</textarea> \
5152
</div> \
5253
</div> \
5354
<div class="modal-footer"> \
@@ -93,4 +94,4 @@
9394
}
9495

9596
$.oc.inspector.propertyEditors.text = TextEditor
96-
}(window.jQuery);
97+
}(window.jQuery);

0 commit comments

Comments
 (0)