Repeater formwidget: add getLoadValue() method #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjauvin
added
the
maintenance
diff --git a/modules/backend/formwidgets/Repeater.php b/modules/backend/formwidgets/Repeater.php
index feb19f10e..ad6b0734c 100644
--- a/modules/backend/formwidgets/Repeater.php
+++ b/modules/backend/formwidgets/Repeater.php
@@ -344,6 +344,8 @@ protected function makeItemFormWidget($index = 0, $groupCode = null)
public function getLoadValue()
{
+ // this resolves the issue, but I'm guessing might break something else
+ return parent::getLoadValue();
return ($this->loaded === true) ? post($this->formField->getName()) : parent::getLoadValue();
} |
mjauvin
changed the title
|
I added a sensitive field to the Winter.Test plugin here to help with this: wintercms/wn-test-plugin@eacde47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened this PR to improve the code path leading to the underlying issue, and help us find a solution.
Remove redundant code by implementing
getLoadValue()method.Try to Fix #1321