Skip to content

Commit 3c7f26b

Browse files
MartinMedekjcechace
authored andcommitted
DBZ-5165 fixing comments from code review
1 parent 301ecd4 commit 3c7f26b

15 files changed

+37
-46
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,3 @@ gen/
3535

3636
jenkins-jobs/docker/rhel_kafka/plugins
3737
jenkins-jobs/docker/artifact-server/plugins
38-
/jenkins-jobs/docker/debezium-testing-system/secret.yml

debezium-testing/debezium-testing-system/src/main/java/io/debezium/testing/system/tools/OpenShiftUtils.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,7 @@ public void waitForPods(String project, Map<String, String> labels) {
253253
}
254254

255255
public static boolean isRunningFromOcp() {
256-
return ConfigProperties.OCP_URL.isEmpty() ||
257-
ConfigProperties.OCP_USERNAME.isEmpty() ||
258-
ConfigProperties.OCP_PASSWORD.isEmpty();
256+
return ConfigProperties.OCP_URL.isEmpty();
259257
}
260258

261259
/**

debezium-testing/debezium-testing-system/src/main/java/io/debezium/testing/system/tools/databases/AbstractOcpDatabaseController.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public int getDatabasePort() {
9999
@Override
100100
public String getPublicDatabaseHostname() {
101101
if (isRunningFromOcp()) {
102-
LOGGER.info("Running from OCP, using local database hostname");
102+
LOGGER.info("Running from OCP, using internal database hostname");
103103
return getDatabaseHostname();
104104
}
105105
awaitIngress();
@@ -110,7 +110,7 @@ public String getPublicDatabaseHostname() {
110110
@Override
111111
public int getPublicDatabasePort() {
112112
if (isRunningFromOcp()) {
113-
LOGGER.info("Running from OCP, using local database port");
113+
LOGGER.info("Running from OCP, using internal database port");
114114
return getDatabasePort();
115115
}
116116
awaitIngress();

debezium-testing/debezium-testing-system/src/main/java/io/debezium/testing/system/tools/databases/AbstractOcpDatabaseDeployer.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ public B withPullSecrets(String yamlPath) {
139139
}
140140

141141
private boolean isLbService(String yamlPath) {
142-
return yamlPath.contains("-lb.");
142+
Service service = YAML.fromResource(yamlPath, Service.class);
143+
return "LoadBalancer".equals(service.getSpec().getType());
143144
}
144145
}
145146
}

debezium-testing/debezium-testing-system/src/test/java/io/debezium/testing/system/fixtures/OcpClient.java

+5-6
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,14 @@ public OcpClient(@NotNull ExtensionContext.Store store) {
3434
public void setup() {
3535
ConfigBuilder configBuilder = new ConfigBuilder();
3636
if (!isRunningFromOcp()) {
37+
LOGGER.info("Running outside OCP, using OCP credentials passed from parameters");
3738
configBuilder.withMasterUrl(ConfigProperties.OCP_URL.get())
3839
.withUsername(ConfigProperties.OCP_USERNAME.get())
39-
.withPassword(ConfigProperties.OCP_PASSWORD.get())
40-
.withRequestRetryBackoffLimit(ConfigProperties.OCP_REQUEST_RETRY_BACKOFF_LIMIT)
41-
.withTrustCerts(true);
42-
}
43-
else {
44-
LOGGER.info("OCP credentials not provided, using default config.");
40+
.withPassword(ConfigProperties.OCP_PASSWORD.get());
4541
}
42+
configBuilder.withRequestRetryBackoffLimit(ConfigProperties.OCP_REQUEST_RETRY_BACKOFF_LIMIT)
43+
.withTrustCerts(true);
44+
4645
client = new DefaultOpenShiftClient(configBuilder.build());
4746
store(OpenShiftClient.class, client);
4847
}

jenkins-jobs/docker/debezium-testing-system/Dockerfile

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM fedora:35
1+
FROM fedora:35 AS base
22

33
RUN dnf -y install git unzip zip findutils
44

@@ -11,19 +11,23 @@ ARG sdkman_init="/root/.sdkman/bin/sdkman-init.sh"
1111

1212
RUN curl -s "https://get.sdkman.io" | bash
1313
RUN source $sdkman_init &&\
14-
sdk install java 17.0.2-open&&\
15-
sdk install maven 3.8.4
14+
sdk install java 17.0.2-open
1615

1716
# this runs when only when dbz repo/branch is changed
1817
ARG repository
1918
ARG branch
2019

2120
RUN git clone --branch $branch $repository /testsuite/debezium
22-
RUN source $sdkman_init && mvn clean install -DskipTests -DskipITs -f /testsuite/debezium/pom.xml
21+
RUN source $sdkman_init && pushd /testsuite/debezium && ./mvnw clean install -DskipTests -DskipITs
2322

2423
COPY testsuite-deployment.sh /testsuite/testsuite-deployment.sh
2524
RUN chmod a+x /testsuite/testsuite-deployment.sh
2625

2726
COPY library.sh /testsuite/library.sh
2827

2928
ENTRYPOINT /testsuite/testsuite-deployment.sh
29+
30+
FROM base AS downstream
31+
32+
COPY apicurio-registry-install-examples.zip /testsuite/apicurio.zip
33+
COPY amq-streams-install-examples.zip /testsuite/strimzi.zip

jenkins-jobs/docker/debezium-testing-system/downstream/Dockerfile

-4
This file was deleted.

jenkins-jobs/docker/debezium-testing-system/library.sh

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ clone_component()
1919

2020
if [ "${COMPONENT}" != "apicurio" ] && [ "${COMPONENT}" != "strimzi" ] ;
2121
then
22+
echo "unknown component: ${COMPONENT}"
2223
exit 2 ;
2324
fi ;
2425

jenkins-jobs/docker/debezium-testing-system/testsuite-deployment.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ if [ -n "${DBZ_KAFKA_VERSION}" ] ; then
5959
OPTIONAL_ARGS+=("-Dversion.kafka=${DBZ_KAFKA_VERSION}")
6060
fi
6161

62-
mvn install -pl debezium-testing/debezium-testing-system -PsystemITs,oracleITs \
62+
./mvnw install -pl debezium-testing/debezium-testing-system -PsystemITs,oracleITs \
6363
-Docp.project.debezium="${DBZ_OCP_PROJECT_DEBEZIUM}" \
6464
-Docp.project.db2="${DBZ_OCP_PROJECT_DB2}" \
6565
-Docp.project.mongo="${DBZ_OCP_PROJECT_MONGO}" \

jenkins-jobs/job-dsl/ocp_downstream_system_test_image_prepare.groovy

-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ pipelineJob('ocp-debezium-testing-downstream-system-image-prepare') {
1111
}
1212

1313
parameters {
14-
stringParam('PARENT_DBZ_GIT_REPOSITORY', 'https://github.com/debezium/debezium.git', 'Repository used to build the docker image')
15-
stringParam('PARENT_DBZ_GIT_BRANCH', 'main')
1614
stringParam('DBZ_GIT_REPOSITORY', 'https://github.com/debezium/debezium.git', 'Repository from which Debezium sources are cloned into docker image')
1715
stringParam('DBZ_GIT_BRANCH', 'main', 'A branch/tag of Debezium sources')
1816
stringParam('TAG', 'latest', 'Docker image tag')

jenkins-jobs/job-dsl/ocp_system_test.groovy

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ pipelineJob('ocp-system-test') {
1919
booleanParam('TEST_APICURIO_REGISTRY', false, 'Run tests with Apicurio Registry and Avro serialization')
2020

2121
booleanParam('STRIMZI_KC_BUILD', false, 'True -> use artifact server, false -> dbz connect image')
22-
stringParam('DBZ_CONNECT_IMAGE', 'quay.io/rh_integration/test-strimzi-kafka:strz-latest-kafka-3.1.0-apc-2.2.3.Final-dbz-2.0.0-SNAPSHOT', 'Debezium connect image')
23-
stringParam('ARTIFACT_SERVER_IMAGE', 'quay.io/rh_integration/test-artifact-server:2.0.0-SNAPSHOT', 'Artifact server image')
22+
stringParam('DBZ_CONNECT_IMAGE', '', 'Debezium connect image')
23+
stringParam('ARTIFACT_SERVER_IMAGE', '', 'Artifact server image')
2424
stringParam('APICURIO_VERSION', '2.2.3.Final', 'Apicurio version')
2525
stringParam('KAFKA_VERSION', '', 'Kafka version')
2626

jenkins-jobs/job-dsl/ocp_upstream_system_test_image_prepare.groovy

-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ pipelineJob('ocp-debezium-testing-upstream-system-image-prepare') {
1111
}
1212

1313
parameters {
14-
stringParam('PARENT_DBZ_GIT_REPOSITORY', 'https://github.com/debezium/debezium.git', 'Repository used to build the docker image')
15-
stringParam('PARENT_DBZ_GIT_BRANCH', 'main')
1614
stringParam('DBZ_GIT_REPOSITORY', 'https://github.com/debezium/debezium.git', 'Repository from which Debezium sources are cloned into docker image')
1715
stringParam('DBZ_GIT_BRANCH', 'main', 'A branch/tag of Debezium sources')
1816
stringParam('TAG', 'latest', 'Docker image tag')

jenkins-jobs/pipelines/downstream_system_test_image_pipeline.groovy

+9-12
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ pipeline {
1414
steps {
1515
checkout([
1616
$class : 'GitSCM',
17-
branches : [[name: "${PARENT_DBZ_GIT_BRANCH}"]],
18-
userRemoteConfigs: [[url: "${PARENT_DBZ_GIT_REPOSITORY}"]],
17+
branches : [[name: "${DBZ_GIT_BRANCH}"]],
18+
userRemoteConfigs: [[url: "${DBZ_GIT_REPOSITORY}"]],
1919
extensions : [[$class : 'RelativeTargetDirectory',
2020
relativeTargetDir: 'debezium']],
2121
])
@@ -30,15 +30,15 @@ pipeline {
3030
expression { !params.APICURIO_PREPARE_BUILD_NUMBER }
3131
}
3232
steps {
33-
copyArtifacts projectName: 'ocp-downstream-apicurio-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system/downstream' ,filter: 'apicurio-registry-install-examples.zip', selector: lastSuccessful()
33+
copyArtifacts projectName: 'ocp-downstream-apicurio-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system' ,filter: 'apicurio-registry-install-examples.zip', selector: lastSuccessful()
3434
}
3535
}
3636
stage('Copy apicurio artifacts') {
3737
when {
3838
expression { params.APICURIO_PREPARE_BUILD_NUMBER }
3939
}
4040
steps {
41-
copyArtifacts projectName: 'ocp-downstream-apicurio-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system/downstream' , filter: 'apicurio-registry-install-examples.zip', selector: specific(params.APICURIO_PREPARE_BUILD_NUMBER)
41+
copyArtifacts projectName: 'ocp-downstream-apicurio-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system' , filter: 'apicurio-registry-install-examples.zip', selector: specific(params.APICURIO_PREPARE_BUILD_NUMBER)
4242
}
4343
}
4444

@@ -47,15 +47,15 @@ pipeline {
4747
expression { !params.STRIMZI_PREPARE_BUILD_NUMBER }
4848
}
4949
steps {
50-
copyArtifacts projectName: 'ocp-downstream-strimzi-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system/downstream' , filter: 'amq-streams-install-examples.zip', selector: lastSuccessful()
50+
copyArtifacts projectName: 'ocp-downstream-strimzi-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system' , filter: 'amq-streams-install-examples.zip', selector: lastSuccessful()
5151
}
5252
}
5353
stage('Copy strimzi artifacts') {
5454
when {
5555
expression { params.STRIMZI_PREPARE_BUILD_NUMBER }
5656
}
5757
steps {
58-
copyArtifacts projectName: 'ocp-downstream-strimzi-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system/downstream' , filter: 'amq-streams-install-examples.zip', selector: specific(params.STRIMZI_PREPARE_BUILD_NUMBER)
58+
copyArtifacts projectName: 'ocp-downstream-strimzi-prepare-job', target: 'debezium/jenkins-jobs/docker/debezium-testing-system' , filter: 'amq-streams-install-examples.zip', selector: specific(params.STRIMZI_PREPARE_BUILD_NUMBER)
5959
}
6060
}
6161

@@ -67,13 +67,10 @@ pipeline {
6767

6868
sh '''
6969
cd debezium/jenkins-jobs/docker/debezium-testing-system
70-
docker build --build-arg branch=${DBZ_GIT_BRANCH} --build-arg repository=${DBZ_GIT_REPOSITORY} -t testsuite-base:latest .
71-
72-
cd downstream
73-
docker build -t testsuite:latest .
74-
docker tag testsuite:latest quay.io/rh_integration/dbz-testing-system:${TAG}
70+
DOCKER_IMAGE=quay.io/rh_integration/dbz-testing-system:${TAG}
71+
docker build --build-arg branch=${DBZ_GIT_BRANCH} --build-arg repository=${DBZ_GIT_REPOSITORY} --target downstream -t ${DOCKER_IMAGE} .
7572
docker login -u ${QUAY_USERNAME} -p ${QUAY_PASSWORD} quay.io
76-
docker push quay.io/rh_integration/dbz-testing-system:${TAG}
73+
docker push ${DOCKER_IMAGE}
7774
'''
7875
}
7976
}

jenkins-jobs/pipelines/ocp_system_pipeline.groovy

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pipeline {
4444
fi
4545
4646
FILENAME="testsuite-job"
47-
SECRET_NAME=$(cat ${SECRET_PATH} | grep name | awk '{print $2;}')
47+
PULL_SECRET_NAME=$(cat ${SECRET_PATH} | grep name | awk '{print $2;}')
4848
4949
cd ${WORKSPACE}/debezium
5050
jenkins-jobs/docker/debezium-testing-system/deployment-template.sh --filename "${FILENAME}" \

jenkins-jobs/pipelines/upstream_system_test_image_pipeline.groovy

+5-5
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ pipeline {
1414
steps {
1515
checkout([
1616
$class : 'GitSCM',
17-
branches : [[name: "${PARENT_DBZ_GIT_BRANCH}"]],
18-
userRemoteConfigs: [[url: "${PARENT_DBZ_GIT_REPOSITORY}"]],
17+
branches : [[name: "${DBZ_GIT_BRANCH}"]],
18+
userRemoteConfigs: [[url: "${DBZ_GIT_REPOSITORY}"]],
1919
extensions : [[$class : 'RelativeTargetDirectory',
2020
relativeTargetDir: 'debezium']],
2121
])
@@ -32,10 +32,10 @@ pipeline {
3232
]) {
3333
sh '''
3434
pushd debezium/jenkins-jobs/docker/debezium-testing-system
35-
docker build --build-arg branch=${DBZ_GIT_BRANCH} --build-arg repository=${DBZ_GIT_REPOSITORY} -t testsuite:upstream .
36-
docker tag testsuite:upstream quay.io/rh_integration/dbz-testing-system:${TAG}
35+
DOCKER_IMAGE=quay.io/rh_integration/dbz-testing-system:${TAG}
36+
docker build --build-arg branch=${DBZ_GIT_BRANCH} --build-arg repository=${DBZ_GIT_REPOSITORY} --target base -t ${DOCKER_IMAGE} .
3737
docker login -u ${QUAY_USERNAME} -p ${QUAY_PASSWORD} quay.io
38-
docker push quay.io/rh_integration/dbz-testing-system:${TAG}
38+
docker push ${DOCKER_IMAGE}
3939
'''
4040
}
4141
}

0 commit comments

Comments
 (0)