Throw an error if run on an ignored file #366
Conversation
Norris1z
force-pushed
the
display_an_error_if_run_on_an_ignored_file
branch
from
bf50b0c to
51dcdda
Compare
|
@sindresorhus should it throw an error or a console.error with a process.exit |
|
This change needs tests. |
|
You're missing #238 (comment) |
|
The |
cli-main.js
Outdated
| @@ -138,6 +139,22 @@ const log = report => { | |||
| process.exit(report.errorCount === 0 ? 0 : 1); | |||
| }; | |||
|
|
|||
| const throwIfFileIsIgnored = file => { | |||
| if (input.includes(file)) { | |||
| throw new Error('You cannot run xo on an ignored file'); | |||
There was a problem hiding this comment.
The error should mention the file path.
|
|
@sindresorhus I had to modify a test to get this to work because this pr changes the behaviour of that test. Also i think #238 (comment) has already been taken care of because the input array holds all files that match the |
sindresorhus
force-pushed
the
master
branch
2 times, most recently
from
9bbe1bf to
2ab0a69
Compare
|
Given the age I'm going to close this PR, but it's definitely still a welcome change. Please open a new PR if you intend to work on it again |
This PR fixes #238 and it throws an error if you call xo on a single file which is ignored.