dig further into the runc hole

Author: yoshuawuyts

README.md

@@ -44,37 +44,10 @@ electron.crashReporter.start({
 })
 ```
 
-### Unit file
-```service
-[Unit]
-Description=Container myalpine
-
-[Service]
-Environment=NODE_ENV=production
-Environment=PORT=8081
-Environment=CRASH_REPORTS_PATH=/root/reports
-ExecStart=/usr/bin/systemd-nspawn \
-  --quiet \
-  --keep-unit \
-  --boot \
-  --link-journal=try-guest \
-  --directory=/var/lib/container/electron-crash-reporter-service \
-  --network-macvlan=eth0 \
-  /usr/bin/env node \
-  /usr/root/electron-crash-reporter-service/index.js
-KillMode=mixed
-Type=notify
-RestartForceExitStatus=133
-SuccessExitStatus=133
-
-[Install]
-WantedBy=multi-user.target
-```
-
 ## Environment variables
 ```sh
 PORT [80]                                # Set the port the service should listen to
-CRASH_REPORTS_PATH [/var/crash-reports]  # Location to store crash reports
+STORAGE_PATH [/var/crash-reports]  # Location to store crash reports
 NODE_ENV [production]                    # production|development
 ```
 
@@ -87,6 +60,37 @@ NODE_ENV [production]                    # production|development
 ## Peer Dependencies
 None
 
+## Unit file
+Save the unit file as `/etc/systemd/system/electron-crash-reporter.service`,
+and the application image as `/images/electron-crash-report-service.aci`
+
+```unit
+[Unit]
+Description=electron-crash-report-service
+Requires=network-online.target
+After=network-online.target
+
+[Service]
+Slice=machine.slice
+Delegate=true
+CPUQuota=10%
+MemoryLimit=1G
+Environment=PORT=80
+Environment=STORAGE_PATH=/var/crash-reports
+Environment=NODE_ENV=production
+ExecStart=/usr/bin/rkt run --inherit-env /images/electron-crash-report-service.aci
+ExecStopPost=/usr/bin/rkt gc --mark-only
+KillMode=mixed
+Restart=always
+```
+
+You can then run it using `systemctl`:
+```sh
+$ sudo systemctl start etcd.service
+$ sudo systemctl stop etcd.service
+$ sudo systemctl restart etcd.service
+```
+
 ## See Also
 - [electron/api/crash-reporters](https://github.com/electron/electron/blob/master/docs/api/crash-reporter.md)
 - [feross/webtorrent.io](https://github.com/feross/webtorrent.io/blob/master/server/desktop-api.js)

build.sh

@@ -39,7 +39,7 @@ acbuild --debug run -- npm install --quiet --production --prefix=/var/www
 acbuild --debug port add http tcp 80
 acbuild --debug environment add PORT 80
 acbuild --debug environment add NODE_ENV 'production'
-acbuild --debug environment add CRASH_REPORTS_PATH '/var/crash-reports'
+acbuild --debug environment add STORAGE_PATH '/var/crash-reports'
 
 # Finalize
 acbuild --debug write --overwrite "${OUTDIR}/${NAME}.aci"

index.js

@@ -8,7 +8,7 @@ var pino = require('pino')
 var fs = require('fs')
 
 var config = {
-  CRASH_REPORTS_PATH: String,
+  STORAGE_PATH: String,
   NODE_ENV: String,
   PORT: String
 }
@@ -46,13 +46,13 @@ var errors = {
   }
 }
 
-mkdirp.sync(env.CRASH_REPORTS_PATH)
+mkdirp.sync(env.STORAGE_PATH)
 
 router.route('GET', '/404', function (req, res, ctx) {
   return res.end(errors.ENOTFOUND(req, res))
 })
 
-var upload = multer({ DEST: env.CRASH_REPORTS_PATH }).single('upload_file_minidumps')
+var upload = multer({ DEST: env.STORAGE_PATH }).single('upload_file_minidumps')
 router.route('POST', '/crash-report', function (req, res, ctx) {
   upload(req, res, function (err) {
     if (err) return res.end(errors.EREPORTPARSE(req, res, err))

package.json

@@ -6,7 +6,7 @@
   "license": "MIT",
   "scripts": {
     "deps": "dependency-check . && dependency-check . --extra --no-dev",
-    "start": "CRASH_REPORTS_PATH=/tmp/crash-reports NODE_ENV=development PORT=8080 nodemon . | pino-colada",
+    "start": "STORAGE_PATH=/tmp/crash-reports NODE_ENV=development PORT=8080 nodemon . | pino-colada",
     "test": "standard && npm run deps",
     "coverage": "nyc report --reporter=text-lcov > coverage.lcov"
   },