Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass topic name to message serializer #370

Closed
robertcoltheart opened this issue Feb 27, 2025 · 2 comments
Closed

Pass topic name to message serializer #370

robertcoltheart opened this issue Feb 27, 2025 · 2 comments

Comments

@robertcoltheart
Copy link

I noticed that the Avro schema registry isn't supported, and I'd like to contribute to build in that support.

The first part of this would be to pass the topic/path name to the message serializer, as this is required by the Avro serializer to send to the schema registry.

I'll contribute a PR for this shortly.

@zarusz
Copy link
Owner

zarusz commented Feb 28, 2025

hello @robertcoltheart, that sounds nice.

Perhaps if you could approach the path/topic passing to the serializer by having an additional serialization interface to be implemented similar to the one I did for SQS

#region Implementation of IMessageSerializer<string>

The SQS provider expected a string in the payload, so instead of serializing to byte[] the transport prefer the specialized string interface if one exists on the chosen serializer.

Of course, if we need to pass the path, and are forced to introduce a breaking change to IMessageSerializer, then it will be okay too.

@robertcoltheart
Copy link
Author

This is completed, will raise a new issue for adding in schema registry support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants