allow failed afl mapping to allow non-forkserver usage #3087
+87
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokatoka
reviewed
Mar 18, 2025
libafl_targets/src/forkserver.rs
Outdated
| /// | ||
| /// # Note | ||
| /// | ||
| /// The function's logic is written in C and this code is a wrapper. | ||
| pub fn map_shared_memory() { | ||
| pub fn map_shared_memory() -> u8 { |
There was a problem hiding this comment.
Can you add
let ret = unsafe {__afl_map_shm()};
if ret == 0 {
log::info!("running fuzzer in replay mode");
}
or any log you want
|
wait but you sure this really works? |
|
Or it simply points to a global array by default? in that case yeah it works. |
Oh sorry, I should set the PR as draft. I expect everything to get merged once I port-ed unicornafl to rust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation blocks "non-forkserver" usage due to
exit(1)immediately. This PR fixes it.Common usages include building binaries for both fuzzing and replaying crashes. My usage is rewriting unicornafl to rust.
Checklist
./scripts/precommit.shand addressed all comments