deploy to github pages #745
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deployed to https://msg-adamant-pr-745.surge.sh 🚀 |
.github/workflows/github-pages.yml
Outdated
| - name: Debug dist folder | ||
| run: ls -R ./dist |
There was a problem hiding this comment.
Not fixed. Remove the step at all. Don't comment it.
| - name: Deploy | ||
| uses: peaceiris/actions-gh-pages@v4 |
There was a problem hiding this comment.
Why not using the official GitHub action actions/deploy-pages?
https://github.com/actions/deploy-pages
| GITHUB_REPO_NAME: ${{ github.event.repository.name }} | ||
| VITE_GITHUB_REPO_NAME: /${{ github.event.repository.name }} |
There was a problem hiding this comment.
Are you sure you need both ENV variables? Can you explain why?
There was a problem hiding this comment.
Not fixed. Remove GITHUB_REPO_NAME if you don't use it.
vite-base.config.ts
Outdated
| import dotenv from 'dotenv'; | ||
| // Загрузка переменных из .env | ||
| dotenv.config(); | ||
|
|
||
| let additional_asset_address = '/'; | ||
|
|
||
| if (process.env.GITHUB_REPO_NAME) { | ||
| additional_asset_address = `/${process.env.GITHUB_REPO_NAME}/`; | ||
| } |
There was a problem hiding this comment.
Why do you import dotenv here if you can just use process.env.GITHUB_REPO_NAME?
There was a problem hiding this comment.
Simplify the code, e.g.:
const publicBasePath = process.env.GITHUB_REPO_NAME ?? "/"
| GITHUB_REPO_NAME: ${{ github.event.repository.name }} | ||
| VITE_GITHUB_REPO_NAME: /${{ github.event.repository.name }} |
There was a problem hiding this comment.
Not fixed. Remove GITHUB_REPO_NAME if you don't use it.
.github/workflows/github-pages.yml
Outdated
| - name: Debug dist folder | ||
| run: ls -R ./dist |
There was a problem hiding this comment.
Not fixed. Remove the step at all. Don't comment it.
please a little attention to this screenshot