Create and use MAV_ parameter namespace #29568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it would be nice for the MAVn subgroups to be SUBGROUPPTR so they appear when allocated |
|
|
|
Good idea! |
peterbarker
force-pushed
the
pr/gcs-params
branch
3 times, most recently
from
4d66ce4 to
6539666
Compare
Move serveral parameters in
Move serveral parameters in
Move serveral parameters in
Move serveral parameters in
Move serveral parameters in
Move serveral parameters in Rover: create and use MAV_ parameter namespace Move serveral parameters in
Move serveral parameters in Rover: create and use MAV_ parameter namespace Move serveral parameters in
Move serveral parameters in Rover: create and use MAV_ parameter namespace Move serveral parameters in
Move serveral parameters in
peterbarker
force-pushed
the
pr/gcs-params
branch
from
6539666 to
8b05143
Compare
.... which are sorted. Also reformat this so a simple change doesn't affect more than it should!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only moved one parameter, but
SYSID_MYGCSis also an obvious one to move.Entry is required in each vehicle as we subclass the GCS object for each vehicle (eg.
GCS_Plane)Past this we should sprout
MAVn_OPTIONSso we can move things fromSERIALn_OPTIONS(eg. "private").... and also have
MAV1_SR_EXTRAetc etc.I have tested each vehicle's parameter upgrade individually. The automatic testing script fails because the system ID changes!