-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(s3stream): automate logIdent injection via LogContext #2379
base: main
Are you sure you want to change the base?
Conversation
Hi @misi0202, I noticed your workflow for requesting changes on PRs and wanted to share a GitHub best practice that might help improve collaboration. When a pull request needs revisions, converting it to a draft (rather than closing it) is generally recommended. This approach preserves the conversation history and context while clearly indicating the work-in-progress status to collaborators. It also avoids generating multiple closed/reopened event notifications, which can sometimes cause confusion in tracking changes. The draft feature was introduced specifically for this purpose - you can easily convert PRs using the right sidebar dropdown. When ready, it can be marked "Ready for review" again without losing any context. Just sharing this as a friendly suggestion – feel free to ignore if you have a specific reason for your current approach! |
Thanks for your suggestion,I have changed this PR to draft and I did modify two files by mistake. |
|
Apologies for the confusion. The S3Stream E2E Test has been recently broken, and this error is unrelated to your changes in this PR. |
Using
com.Automq.Stream.Utils.LogContext
forcom.Automq.Stream.S3.S3Stream
logIdent automatic injection in prefixSummary of testing strategy (including rationale)
Test the log output format in S3Stream
Committer Checklist (excluded from commit message)