Correct the usage of getConfiguration('autolispext') by modify the extensionDevelopmentPath #141
+363
−405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigma456
changed the title
Sen-real
reviewed
May 7, 2021
| // CloseParenthesisStyle: 'New line with outer indentation' | ||
| // LongListFormatStyle: 'Fill to margin' | ||
| // Need to remove the \r to do the format output compare | ||
| after(async () => { |
There was a problem hiding this comment.
A suite doesn't have after / before.
It should use setup, teardown, suiteSetup, suiteTeardown.
https://www.w3resource.com/mocha/interfaces.php
JD-Howard
reviewed
Sep 21, 2021
| @@ -22,6 +22,7 @@ | |||
| "preLaunchTask": "buildproject", | |||
| "runtimeExecutable": "${execPath}", | |||
| "args": [ | |||
| "--disable-extensions", | |||
There was a problem hiding this comment.
This was handled in PR #160 and quite a bit more. Make sure you update to the latest before these test additions get added.
JD-Howard
reviewed
Sep 21, 2021
| @@ -6,7 +6,8 @@ async function main() { | |||
| try { | |||
| // The folder containing the Extension Manifest package.json | |||
| // Passed to `--extensionDevelopmentPath` | |||
| const extensionDevelopmentPath = path.resolve(__dirname, '../../../../'); | |||
| // The __dirname is \AutoLispExt\out\test | |||
| const extensionDevelopmentPath = path.resolve(__dirname, '../../'); | |||
There was a problem hiding this comment.
This was handled in PR #160 and quite a bit more. Make sure you update to the latest before these test additions get added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Update to use the correct extensionDevelopmentPath and remove mock method
Abstractions
In our lisp extension test we have wrongly set the extensionDevelopmentPath in runTest.ts so that it will fail to read the configuration('autolispext') and we have to use a workround of mock method for formatter.test.ts
In this subimission I corrected the extensionDevelopmentPath and removed the mock method
Tests performed
Passed local and CI test
Screen shot