Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor @armResourceOperations as the flag for resource operation #5265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Mar 17, 2025

Fix #5260

When swagger input we have configuration request-path-is-non-resource to make a resource become a non-resource. In the TypeSpec world, we use decorator @armResourceOperations to mark a resource operation. Therefore if an operation doesn't have this operation, it means it is not resource operation.

@pshao25 pshao25 marked this pull request as draft March 17, 2025 10:17
@ArcturusZhang
Copy link
Member

I think your current implementation could work in some ways but it does not provide the full functionalities of this configuration.

One of the functionalities for this configuration is that, we could use this configuration to make a "resource" into a non resource, even if it is recognized as resources.
Your current implementation is that we make those interfaces with @armResourceOperations decorators to be resource, and those without to be non-resource, looks like a workaround to our resource detection.
If this is expected, we should change the description accordingly.

@pshao25 pshao25 changed the title Support request-path-is-non-resource for TypeSpec input Honor @armResourceOperations as the flag for resource operation Mar 21, 2025
@pshao25 pshao25 marked this pull request as ready for review March 21, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support request-path-is-non-resource for TypeSpec input
2 participants