Skip to content

avm/res/app/container-app/0.14.0

avm/res/app/container-app/0.14.0: feat: Update scale settings for container app (#4721)
@oZakari oZakari tagged this 13 Mar 18:39 
## Description
This pull request introduces a comprehensive update to the scaling
settings of the Container App module. The changes include consolidating
scaling parameters into a single `scaleSettings` UDT object, updating
the documentation to reflect these changes, and modifying the relevant
Bicep and JSON files to support the new structure.

### Consolidation of Scaling Parameters:
* **BREAKING CHANGE:**
[`avm/res/app/container-app/README.md`](diffhunk://#diff-27de9f4905d48866dea2f3a887fa7a607d2688551bf12434a23ebde92d24ce52R325-R330):
Replaced individual scaling parameters (`scaleMaxReplicas`,
`scaleMinReplicas`, `scaleRules`) with a unified `scaleSettings` object.
Updated descriptions and added details for new parameters.
[[1]](diffhunk://#diff-27de9f4905d48866dea2f3a887fa7a607d2688551bf12434a23ebde92d24ce52R325-R330)
[[2]](diffhunk://#diff-27de9f4905d48866dea2f3a887fa7a607d2688551bf12434a23ebde92d24ce52R460-R467)
[[3]](diffhunk://#diff-27de9f4905d48866dea2f3a887fa7a607d2688551bf12434a23ebde92d24ce52R583-R588)
[[4]](diffhunk://#diff-27de9f4905d48866dea2f3a887fa7a607d2688551bf12434a23ebde92d24ce52L954-R974)
[[5]](diffhunk://#diff-27de9f4905d48866dea2f3a887fa7a607d2688551bf12434a23ebde92d24ce52L1901-R2031)

### Bicep File Updates:
*
[`avm/res/app/container-app/main.bicep`](diffhunk://#diff-7ff2b43ccac3ded86d5955ab921f9a50e826b5b6379b917eaa0978949d795cc6L58-R62):
Updated Bicep definitions to use the new `scaleSettings` object. This
includes defining a new type `scaleType` and modifying the resource
configuration to reference `scaleSettings`.
[[1]](diffhunk://#diff-7ff2b43ccac3ded86d5955ab921f9a50e826b5b6379b917eaa0978949d795cc6L58-R62)
[[2]](diffhunk://#diff-7ff2b43ccac3ded86d5955ab921f9a50e826b5b6379b917eaa0978949d795cc6L285-R282)
[[3]](diffhunk://#diff-7ff2b43ccac3ded86d5955ab921f9a50e826b5b6379b917eaa0978949d795cc6R502-R537)

### JSON File Updates:
*
[`avm/res/app/container-app/main.json`](diffhunk://#diff-c4d118cb5eda31cbd8c09ef11983817aca722f1f4e9cd64376a503fd18f57961R410-R495):
Updated JSON schema to include the new `scaleType` and replaced
individual scaling parameters with `scaleSettings`.
[[1]](diffhunk://#diff-c4d118cb5eda31cbd8c09ef11983817aca722f1f4e9cd64376a503fd18f57961R410-R495)
[[2]](diffhunk://#diff-c4d118cb5eda31cbd8c09ef11983817aca722f1f4e9cd64376a503fd18f57961L795-R888)
[[3]](diffhunk://#diff-c4d118cb5eda31cbd8c09ef11983817aca722f1f4e9cd64376a503fd18f57961L1071-R1146)

### Test Updates:
*
[`avm/res/app/container-app/tests/e2e/max/main.test.bicep`](diffhunk://#diff-f11dd8a6a42396b2f9b2a5649b41d70b5ab314a96345846b747861520a54d190R159-R164):
Modified tests to use the new `scaleSettings` object.

### Version Update:
*
[`avm/res/app/container-app/version.json`](diffhunk://#diff-21b59a8ab8aebf3dfc7b1378420a6aea1d56ac70c92fdaa3f777f06b99d76bc8L3-R3):
Incremented the module version from `0.13` to `0.14` to reflect the
changes.

Fixes #4688

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.app.container-app](https://github.com/oZakari/bicep-registry-modules/actions/workflows/avm.res.app.container-app.yml/badge.svg?branch=scale-settings)](https://github.com/oZakari/bicep-registry-modules/actions/workflows/avm.res.app.container-app.yml)|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [x] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [ ] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: ChrisSidebotham-MSFT <[email protected]>
Assets 2
Loading