Merging #952 (Support for scenarios where access_token is not returned) #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for scenarios where access_token is not returned
kaisong1990
reviewed
Mar 1, 2021
| @@ -783,8 +783,7 @@ - (BOOL)saveAccessTokenWithConfiguration:(MSIDConfiguration *)configuration | |||
| MSIDAccessToken *accessToken = [factory accessTokenFromResponse:response configuration:configuration]; | |||
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
| @@ -43,6 +43,11 @@ - (BOOL)validateTokenResult:(MSIDTokenResult *)tokenResult | |||
| we'd like to throw an error and specify which scopes were granted and which ones not | |||
| */ | |||
|
|
|||
| if (tokenResult.accessToken == nil) | |||
There was a problem hiding this comment.
Should we use NSString msidIsStringNilOrBlank:token?
| { | ||
| if (error) | ||
| { | ||
| *error = MSIDCreateError(MSIDErrorDomain, MSIDErrorInternal, @"Authentication response received without expected accessToken", nil, nil, nil, context.correlationId, nil, YES); | ||
| *error = MSIDCreateError(MSIDErrorDomain, MSIDErrorInternal, @"Authentication response received without expected accessToken and idToken", nil, nil, nil, context.correlationId, nil, YES); |
There was a problem hiding this comment.
Just curious, in which scenario the idToken is nil, is it server error or parsing error at client side?
There was a problem hiding this comment.
Likely some kind of misconfiguration in case of B2C (so server error).
Shouldn't happen in case of AAD since we always pass in scope=openid.
kaisong1990
reviewed
Mar 11, 2021
kaisong1990
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merging a PR from an external contributor: #952
The PR Azure Pipelines checks are not working for forked repos, so opening a new PR to get PR checks completed.
Type of change
Risk
Additional information