Remove check if access_token is not returned for id_token only scenarios #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldalton
reviewed
Feb 26, 2021
| @@ -135,10 +135,6 @@ + (MSALResult *)resultWithMSIDTokenResult:(MSIDTokenResult *)tokenResult | |||
| } | |||
|
|
|||
| NSString *accessToken = [authScheme getClientAccessToken:tokenResult.accessToken popManager:popManager error:error]; | |||
| if (!accessToken) | |||
There was a problem hiding this comment.
Could you also update accessToken property in the MSALResult file to be nullable?
It's currently non null here:
@interface MSALResult : NSObject
#pragma mark - Token response
/** The Access Token requested. */
@property (readonly, nonnull) NSString *accessToken;
There was a problem hiding this comment.
Thanks for the review. In addition to the properties you pointed out, I've changed the properties that depend on accessToken to nullable
oldalton
approved these changes
Feb 26, 2021
Merged
9 tasks
oldalton
added a commit
that referenced
this pull request
Mar 18, 2021
Merging #1253 (Remove check if access_token is not returned for id_token only scenarios)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove the check that treated all cases without access_token as errors, and support scenarios with only id_token (mainly Azure AD B2C).
#852
It relies on the following pull request.
AzureAD/microsoft-authentication-library-common-for-objc#952
Type of change
Risk
Additional information