-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Go SDK V2 Upgrade, Single Measure Support #3
base: master
Are you sure you want to change the base?
Conversation
cmd/tsbs_generate_queries/databases/timestream/devops_single_measure_test.go
Show resolved
Hide resolved
cmd/tsbs_generate_queries/databases/timestream/devops_single_measure_test.go
Show resolved
Hide resolved
cmd/tsbs_generate_queries/databases/timestream/devops_single_measure_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after comments have been addressed
Created a PR against this branch for addressing all of the comments. Updating |
This PR upgrades the AWS go SDK used for connecting to Timestream. Added mode for toggling between single-measure and multi-measure records, including for query generation with relevant tests.
To run unit tests for generated queries, you can navigate to
cmd/tsbs_generate_queries/databases/timestream
and rungo test -v
.Sample end-to-end flow:
And unzip with
gunzip /tmp/timestream-data.gz
Multi-measure:
Single-measure:
Create the config with:
And update config values:
/tmp/timestream-data
)use-single-measure-records
to trueworkers
(really slow with just 1)Run with
--print-responses
to track progress of your queries.