add(rnafusion support) #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ChrOertlin
commented
Mar 19, 2024
•
ChrOertlin
commented
- multiqc_picard_dups.json
- multiqc_picard_insertSize.json
- multiqc_picard_RnaSeqMetrics.json
- multiqc_fastp.json
- multiqc_star.json
- multiqc_general_stats.json - needs a special parser
henrikstranneheim
approved these changes
Mar 19, 2024
janus/models/multiqc/models.py
Outdated
| @@ -419,7 +419,7 @@ class STARAlignment(BaseModel): | |||
| unmapped_other: float | |||
|
|
|||
|
|
|||
| class RNAfusionGeneralStats(BaseModel): | |||
| class RNAFusionGeneralStatsForwardSummary(BaseModel): | |||
There was a problem hiding this comment.
And the reverse?
There was a problem hiding this comment.
Changing for RNAFusionGeneralStatsSummary if @ChrOertlin approves
There was a problem hiding this comment.
Forward and reverse should have the same fields, so they are encompassed in only one data class
diitaz93
reviewed
Mar 20, 2024
janus/models/multiqc/models.py
Outdated
|
|
||
|
|
||
| class RNAFusionGeneralStats(BaseModel): | ||
| summary: RNAFusionGeneralStatsForwardSummary |
There was a problem hiding this comment.
Suggested change
| summary: RNAFusionGeneralStatsForwardSummary | |
| summary: RNAFusionGeneralStatsSummary |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.